Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 682743003: Fix pkg-config issue with cras for Chrome OS build. (Closed)

Created:
6 years, 1 month ago by Ben Chan
Modified:
6 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, pwestin(chromium), alokp
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix pkg-config issue with cras for Chrome OS build. BUG=None TEST=Run `gn gen` with 'os="chromeos" use_cras=true'. Committed: https://crrev.com/77287dc5c9fb6d6a17febdcfb33a792523dca01a Cr-Commit-Position: refs/heads/master@{#301477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/audio/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Chan
6 years, 1 month ago (2014-10-27 20:54:01 UTC) #2
DaleCurtis
lgtm
6 years, 1 month ago (2014-10-27 21:32:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682743003/1
6 years, 1 month ago (2014-10-27 21:37:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 23:19:25 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:20:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77287dc5c9fb6d6a17febdcfb33a792523dca01a
Cr-Commit-Position: refs/heads/master@{#301477}

Powered by Google App Engine
This is Rietveld 408576698