gpu/command_buffer/service/gpu_scheduler_unittest.cc - Issue 682743002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gpu_scheduler_unittest.cc

Issue 682743002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc ('k') | gpu/command_buffer/service/gpu_service_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gpu_scheduler_unittest.cc

diff --git a/gpu/command_buffer/service/gpu_scheduler_unittest.cc b/gpu/command_buffer/service/gpu_scheduler_unittest.cc

index c658d2bf7571b347e56ce2df2f5b6887f0551ea5..d8233ecbd678ef4470e801201ae046728a978df0 100644

--- a/gpu/command_buffer/service/gpu_scheduler_unittest.cc

+++ b/gpu/command_buffer/service/gpu_scheduler_unittest.cc

@@ -32,7 +32,7 @@ class GpuSchedulerTest : public testing::Test {

protected:

static const int32 kTransferBufferId = 123;

- virtual void SetUp() {

+ void SetUp() override {

scoped_ptr<base::SharedMemory> shared_memory(new ::base::SharedMemory);

shared_memory->CreateAndMapAnonymous(kRingBufferSize);

buffer_ = static_cast<int32*>(shared_memory->memory());

@@ -62,7 +62,7 @@ class GpuSchedulerTest : public testing::Test {

EXPECT_TRUE(scheduler_->SetGetBuffer(kTransferBufferId));

}

- virtual void TearDown() {

+ void TearDown() override {

// Ensure that any unexpected tasks posted by the GPU scheduler are executed

// in order to fail the test.

base::MessageLoop::current()->RunUntilIdle();