Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: gpu/config/gpu_test_expectations_parser_unittest.cc

Issue 682743002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "gpu/config/gpu_test_expectations_parser.h" 6 #include "gpu/config/gpu_test_expectations_parser.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace gpu { 9 namespace gpu {
10 10
11 class GPUTestExpectationsParserTest : public testing::Test { 11 class GPUTestExpectationsParserTest : public testing::Test {
12 public: 12 public:
13 GPUTestExpectationsParserTest() { } 13 GPUTestExpectationsParserTest() { }
14 14
15 virtual ~GPUTestExpectationsParserTest() { } 15 ~GPUTestExpectationsParserTest() override {}
16 16
17 const GPUTestBotConfig& bot_config() const { 17 const GPUTestBotConfig& bot_config() const {
18 return bot_config_; 18 return bot_config_;
19 } 19 }
20 20
21 protected: 21 protected:
22 virtual void SetUp() { 22 void SetUp() override {
23 bot_config_.set_os(GPUTestConfig::kOsWin7); 23 bot_config_.set_os(GPUTestConfig::kOsWin7);
24 bot_config_.set_build_type(GPUTestConfig::kBuildTypeRelease); 24 bot_config_.set_build_type(GPUTestConfig::kBuildTypeRelease);
25 bot_config_.AddGPUVendor(0x10de); 25 bot_config_.AddGPUVendor(0x10de);
26 bot_config_.set_gpu_device_id(0x0640); 26 bot_config_.set_gpu_device_id(0x0640);
27 ASSERT_TRUE(bot_config_.IsValid()); 27 ASSERT_TRUE(bot_config_.IsValid());
28 } 28 }
29 29
30 virtual void TearDown() { } 30 void TearDown() override {}
31 31
32 private: 32 private:
33 GPUTestBotConfig bot_config_; 33 GPUTestBotConfig bot_config_;
34 }; 34 };
35 35
36 TEST_F(GPUTestExpectationsParserTest, CommentOnly) { 36 TEST_F(GPUTestExpectationsParserTest, CommentOnly) {
37 const std::string text = 37 const std::string text =
38 " \n" 38 " \n"
39 "// This is just some comment\n" 39 "// This is just some comment\n"
40 ""; 40 "";
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 EXPECT_TRUE(parser.LoadTestExpectations(text)); 236 EXPECT_TRUE(parser.LoadTestExpectations(text));
237 EXPECT_EQ(0u, parser.GetErrorMessages().size()); 237 EXPECT_EQ(0u, parser.GetErrorMessages().size());
238 EXPECT_EQ(GPUTestExpectationsParser::kGpuTestFail, 238 EXPECT_EQ(GPUTestExpectationsParser::kGpuTestFail,
239 parser.GetTestExpectation("MyTest0", bot_config())); 239 parser.GetTestExpectation("MyTest0", bot_config()));
240 EXPECT_EQ(GPUTestExpectationsParser::kGpuTestPass, 240 EXPECT_EQ(GPUTestExpectationsParser::kGpuTestPass,
241 parser.GetTestExpectation("OtherTest", bot_config())); 241 parser.GetTestExpectation("OtherTest", bot_config()));
242 } 242 }
243 243
244 } // namespace gpu 244 } // namespace gpu
245 245
OLDNEW
« no previous file with comments | « gpu/config/gpu_test_config_unittest.cc ('k') | gpu/tools/compositor_model_bench/forward_render_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698