Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: gpu/command_buffer/service/renderbuffer_manager_unittest.cc

Issue 682743002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/renderbuffer_manager.h" 5 #include "gpu/command_buffer/service/renderbuffer_manager.h"
6 6
7 #include <set> 7 #include <set>
8 #include "gpu/command_buffer/common/gles2_cmd_utils.h" 8 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
9 #include "gpu/command_buffer/service/gpu_service_test.h" 9 #include "gpu/command_buffer/service/gpu_service_test.h"
10 #include "gpu/command_buffer/service/mocks.h" 10 #include "gpu/command_buffer/service/mocks.h"
(...skipping 11 matching lines...) Expand all
22 static const GLint kMaxSize = 128; 22 static const GLint kMaxSize = 128;
23 static const GLint kMaxSamples = 4; 23 static const GLint kMaxSamples = 4;
24 24
25 protected: 25 protected:
26 void SetUpBase(MemoryTracker* memory_tracker, bool depth24_supported) { 26 void SetUpBase(MemoryTracker* memory_tracker, bool depth24_supported) {
27 GpuServiceTest::SetUp(); 27 GpuServiceTest::SetUp();
28 manager_.reset(new RenderbufferManager( 28 manager_.reset(new RenderbufferManager(
29 memory_tracker, kMaxSize, kMaxSamples, depth24_supported)); 29 memory_tracker, kMaxSize, kMaxSamples, depth24_supported));
30 } 30 }
31 31
32 virtual void TearDown() { 32 void TearDown() override {
33 manager_->Destroy(true); 33 manager_->Destroy(true);
34 manager_.reset(); 34 manager_.reset();
35 GpuServiceTest::TearDown(); 35 GpuServiceTest::TearDown();
36 } 36 }
37 37
38 scoped_ptr<RenderbufferManager> manager_; 38 scoped_ptr<RenderbufferManager> manager_;
39 }; 39 };
40 40
41 class RenderbufferManagerTest : public RenderbufferManagerTestBase { 41 class RenderbufferManagerTest : public RenderbufferManagerTestBase {
42 protected: 42 protected:
43 virtual void SetUp() { 43 void SetUp() override {
44 bool depth24_supported = false; 44 bool depth24_supported = false;
45 SetUpBase(NULL, depth24_supported); 45 SetUpBase(NULL, depth24_supported);
46 } 46 }
47 }; 47 };
48 48
49 class RenderbufferManagerMemoryTrackerTest 49 class RenderbufferManagerMemoryTrackerTest
50 : public RenderbufferManagerTestBase { 50 : public RenderbufferManagerTestBase {
51 protected: 51 protected:
52 virtual void SetUp() { 52 void SetUp() override {
53 mock_memory_tracker_ = new StrictMock<MockMemoryTracker>(); 53 mock_memory_tracker_ = new StrictMock<MockMemoryTracker>();
54 bool depth24_supported = false; 54 bool depth24_supported = false;
55 SetUpBase(mock_memory_tracker_.get(), depth24_supported); 55 SetUpBase(mock_memory_tracker_.get(), depth24_supported);
56 } 56 }
57 57
58 scoped_refptr<MockMemoryTracker> mock_memory_tracker_; 58 scoped_refptr<MockMemoryTracker> mock_memory_tracker_;
59 }; 59 };
60 60
61 #define EXPECT_MEMORY_ALLOCATION_CHANGE(old_size, new_size, pool) \ 61 #define EXPECT_MEMORY_ALLOCATION_CHANGE(old_size, new_size, pool) \
62 EXPECT_CALL(*mock_memory_tracker_.get(), \ 62 EXPECT_CALL(*mock_memory_tracker_.get(), \
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 // Check the set was acutally getting different signatures. 286 // Check the set was acutally getting different signatures.
287 EXPECT_EQ(5u, string_set.size()); 287 EXPECT_EQ(5u, string_set.size());
288 288
289 EXPECT_CALL(*gl_, DeleteRenderbuffersEXT(1, ::testing::Pointee(kService1Id))) 289 EXPECT_CALL(*gl_, DeleteRenderbuffersEXT(1, ::testing::Pointee(kService1Id)))
290 .Times(1) 290 .Times(1)
291 .RetiresOnSaturation(); 291 .RetiresOnSaturation();
292 } 292 }
293 293
294 class RenderbufferManagerFormatTest : public RenderbufferManagerTestBase { 294 class RenderbufferManagerFormatTest : public RenderbufferManagerTestBase {
295 protected: 295 protected:
296 virtual void SetUp() { 296 void SetUp() override {
297 bool depth24_supported = true; 297 bool depth24_supported = true;
298 SetUpBase(NULL, depth24_supported); 298 SetUpBase(NULL, depth24_supported);
299 } 299 }
300 }; 300 };
301 301
302 TEST_F(RenderbufferManagerFormatTest, UpgradeDepthFormatOnGLES) { 302 TEST_F(RenderbufferManagerFormatTest, UpgradeDepthFormatOnGLES) {
303 gfx::GLImplementation prev_impl = gfx::GetGLImplementation(); 303 gfx::GLImplementation prev_impl = gfx::GetGLImplementation();
304 gfx::SetGLImplementation(gfx::kGLImplementationEGLGLES2); 304 gfx::SetGLImplementation(gfx::kGLImplementationEGLGLES2);
305 GLenum impl_format = 305 GLenum impl_format =
306 manager_->InternalRenderbufferFormatToImplFormat(GL_DEPTH_COMPONENT16); 306 manager_->InternalRenderbufferFormatToImplFormat(GL_DEPTH_COMPONENT16);
307 gfx::SetGLImplementation(prev_impl); 307 gfx::SetGLImplementation(prev_impl);
308 EXPECT_EQ(static_cast<GLenum>(GL_DEPTH_COMPONENT24), impl_format); 308 EXPECT_EQ(static_cast<GLenum>(GL_DEPTH_COMPONENT24), impl_format);
309 } 309 }
310 310
311 TEST_F(RenderbufferManagerFormatTest, UseUnsizedDepthFormatOnNonGLES) { 311 TEST_F(RenderbufferManagerFormatTest, UseUnsizedDepthFormatOnNonGLES) {
312 gfx::GLImplementation prev_impl = gfx::GetGLImplementation(); 312 gfx::GLImplementation prev_impl = gfx::GetGLImplementation();
313 gfx::SetGLImplementation(gfx::kGLImplementationDesktopGL); 313 gfx::SetGLImplementation(gfx::kGLImplementationDesktopGL);
314 GLenum impl_format = 314 GLenum impl_format =
315 manager_->InternalRenderbufferFormatToImplFormat(GL_DEPTH_COMPONENT16); 315 manager_->InternalRenderbufferFormatToImplFormat(GL_DEPTH_COMPONENT16);
316 gfx::SetGLImplementation(prev_impl); 316 gfx::SetGLImplementation(prev_impl);
317 EXPECT_EQ(static_cast<GLenum>(GL_DEPTH_COMPONENT), impl_format); 317 EXPECT_EQ(static_cast<GLenum>(GL_DEPTH_COMPONENT), impl_format);
318 } 318 }
319 319
320 } // namespace gles2 320 } // namespace gles2
321 } // namespace gpu 321 } // namespace gpu
322 322
323 323
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/query_manager_unittest.cc ('k') | gpu/command_buffer/service/shader_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698