Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Side by Side Diff: gpu/command_buffer/service/common_decoder_unittest.cc

Issue 682743002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/common_decoder.h" 5 #include "gpu/command_buffer/service/common_decoder.h"
6 #include "gpu/command_buffer/service/cmd_buffer_engine.h" 6 #include "gpu/command_buffer/service/cmd_buffer_engine.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace gpu { 9 namespace gpu {
10 10
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 const int32 MockCommandBufferEngine::kStartValidShmId; 145 const int32 MockCommandBufferEngine::kStartValidShmId;
146 const int32 MockCommandBufferEngine::kValidShmId; 146 const int32 MockCommandBufferEngine::kValidShmId;
147 const int32 MockCommandBufferEngine::kInvalidShmId; 147 const int32 MockCommandBufferEngine::kInvalidShmId;
148 const size_t MockCommandBufferEngine::kBufferSize; 148 const size_t MockCommandBufferEngine::kBufferSize;
149 const int32 MockCommandBufferEngine::kValidOffset; 149 const int32 MockCommandBufferEngine::kValidOffset;
150 const int32 MockCommandBufferEngine::kInvalidOffset; 150 const int32 MockCommandBufferEngine::kInvalidOffset;
151 151
152 class CommonDecoderTest : public testing::Test { 152 class CommonDecoderTest : public testing::Test {
153 protected: 153 protected:
154 virtual void SetUp() { 154 void SetUp() override { decoder_.set_engine(&engine_); }
155 decoder_.set_engine(&engine_);
156 }
157 155
158 virtual void TearDown() { 156 void TearDown() override {}
159 }
160 157
161 template <typename T> 158 template <typename T>
162 error::Error ExecuteCmd(const T& cmd) { 159 error::Error ExecuteCmd(const T& cmd) {
163 COMPILE_ASSERT(T::kArgFlags == cmd::kFixed, Cmd_kArgFlags_not_kFixed); 160 COMPILE_ASSERT(T::kArgFlags == cmd::kFixed, Cmd_kArgFlags_not_kFixed);
164 return decoder_.DoCommands( 161 return decoder_.DoCommands(
165 1, (const void*)&cmd, ComputeNumEntries(sizeof(cmd)), 0); 162 1, (const void*)&cmd, ComputeNumEntries(sizeof(cmd)), 0);
166 } 163 }
167 164
168 template <typename T> 165 template <typename T>
169 error::Error ExecuteImmediateCmd(const T& cmd, size_t data_size) { 166 error::Error ExecuteImmediateCmd(const T& cmd, size_t data_size) {
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory); 495 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory);
499 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 496 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
500 497
501 // Check that it fails if the size is invalid 498 // Check that it fails if the size is invalid
502 cmd.Init(kBucketId, 0, sizeof(kData) + 1, 499 cmd.Init(kBucketId, 0, sizeof(kData) + 1,
503 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory); 500 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory);
504 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 501 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
505 } 502 }
506 503
507 } // namespace gpu 504 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/command_buffer_service_unittest.cc ('k') | gpu/command_buffer/service/context_group_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698