Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 682713003: Update a bunch of OWNERS files. (Closed)

Created:
6 years, 1 month ago by Ben Goodger (Google)
Modified:
5 years, 10 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, tfarina, jam, kalyank, sadrul, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update a bunch of OWNERS files. Remove v2. R=sky@chromium.org BUG= Committed: https://crrev.com/0ee290d067f9aa291e993c29c7949d5d4c430809 Cr-Commit-Position: refs/heads/master@{#301493}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1425 lines) Patch
M OWNERS View 2 chunks +3 lines, -1 line 1 comment Download
M WATCHLISTS View 2 chunks +4 lines, -8 lines 0 comments Download
M athena/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_modal/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M ui/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/v2/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/v2/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/v2/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
D ui/v2/public/event.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/v2/public/event_dispatcher.h View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/v2/public/event_handler.h View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/v2/public/event_target.h View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/v2/public/layout.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/v2/public/painter.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/v2/public/v2_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/v2/public/view.h View 1 chunk +0 lines, -113 lines 0 comments Download
D ui/v2/public/view_observer.h View 1 chunk +0 lines, -65 lines 0 comments Download
D ui/v2/public/window.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/v2/src/event.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/v2/src/event_dispatcher.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/v2/src/event_processor.h View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/v2/src/event_processor.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/v2/src/layout.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/v2/src/paint_processor.h View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/v2/src/paint_processor.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/v2/src/v2_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/v2/src/view.cc View 1 chunk +0 lines, -302 lines 0 comments Download
D ui/v2/src/view_observer.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/v2/src/view_private.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/v2/src/view_private.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/v2/src/view_unittest.cc View 1 chunk +0 lines, -462 lines 0 comments Download
D ui/v2/src/window.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/v2/v2.gyp View 1 chunk +0 lines, -68 lines 0 comments Download
M ui/views/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/webview/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Ben Goodger (Google)
6 years, 1 month ago (2014-10-27 22:18:08 UTC) #1
sky
LGTM
6 years, 1 month ago (2014-10-27 22:19:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682713003/1
6 years, 1 month ago (2014-10-27 22:23:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 00:03:02 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ee290d067f9aa291e993c29c7949d5d4c430809 Cr-Commit-Position: refs/heads/master@{#301493}
6 years, 1 month ago (2014-10-28 00:03:51 UTC) #6
Nico
5 years, 10 months ago (2015-02-10 18:54:53 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/682713003/diff/1/OWNERS
File OWNERS (right):

https://codereview.chromium.org/682713003/diff/1/OWNERS#newcode16
OWNERS:16: ben@chromium.org
What's the point of emeritus entries in owners files? I've seen them in a few
files by now and I think we shouldn't have them – but that's kinda hard to argue
for if there's one in the toplevel owners file :-P

Powered by Google App Engine
This is Rietveld 408576698