Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 682673002: Make NextCodeLink pointer 8-byte aligned after GC pointer updating uses atomics. (Closed)

Created:
6 years, 1 month ago by dusmil.imgtec
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make NextCodeLink pointer 8-byte aligned after GC pointer updating uses atomics. After r24737 pointer updating is done by atomic operations which strictly require target address to be 8-byte alignment on MIPS64. The alignment is broken on 64-bit arches because InstructionSize is first field and has Int size. Order of fields in object layout are changed to make kNextCodeLinkOffset divisible by 8. The size of code object header remains the same. TEST=cctest/test-debug/* on MIPS64 BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=24914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dusmil.imgtec
6 years, 1 month ago (2014-10-27 16:00:22 UTC) #2
Jakob Kummerow
objects.h LGTM.
6 years, 1 month ago (2014-10-27 16:06:11 UTC) #3
paul.l...
MIPS part also LGTM.
6 years, 1 month ago (2014-10-27 18:02:11 UTC) #4
dusmil.imgtec
6 years, 1 month ago (2014-10-27 18:24:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24914 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698