Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: build/android/test_runner.py

Issue 68263025: Android: removes old "keep_test_server_ports". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index af53bf7f103375f712ae38b7c2bf96b0772c835f..a87474c0542cc183914886524baf6652f490151c 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -177,12 +177,6 @@ def AddJavaTestOptions(option_parser):
help='Saves the JSON file for each UI Perf test.')
option_parser.add_option('--official-build', action='store_true',
help='Run official build tests.')
- option_parser.add_option('--keep_test_server_ports',
- action='store_true',
- help=('Indicates the test server ports must be '
- 'kept. When this is run via a sharder '
- 'the test server ports should be kept and '
- 'should not be reset.'))
option_parser.add_option('--test_data', action='append', default=[],
help=('Each instance defines a directory of test '
'data that should be copied to the target(s) '
@@ -209,10 +203,6 @@ def ProcessJavaTestOptions(options, error_func):
else:
options.exclude_annotations = []
- if not options.keep_test_server_ports:
- if not ports.ResetTestServerPortAllocation():
- raise Exception('Failed to reset test server port.')
-
def AddInstrumentationTestOptions(option_parser):
"""Adds Instrumentation test options to |option_parser|."""
@@ -720,6 +710,8 @@ def RunTestsCommand(command, options, args, option_parser):
devices = _GetAttachedDevices(options.test_device)
forwarder.Forwarder.RemoveHostLog()
+ if not ports.ResetTestServerPortAllocation():
+ raise Exception('Failed to reset test server port.')
if command == 'gtest':
return _RunGTests(options, option_parser.error, devices)
« no previous file with comments | « build/android/pylib/perf/setup.py ('k') | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698