Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 68263009: Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} (Closed)

Created:
7 years, 1 month ago by Andrey Kraynov
Modified:
7 years ago
Reviewers:
tkent, yosin_UTC9, eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@upload-review-3
Visibility:
Public.

Description

Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} This patch copies Source/web/WebFrameImpl.{cpp,h} into Source/web/TextFinder.{cpp,h} for decoupling WebFrameImpl and text finder. Another patch will complete decoupling. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162937

Patch Set 1 #

Patch Set 2 : Rename InFrameFinder class to TextFinder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
A + Source/web/TextFinder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/web/TextFinder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
yosin_UTC9
ACK +tkent for committing
7 years, 1 month ago (2013-11-14 01:42:44 UTC) #1
tkent
I feel the name 'InFrameFinder' doesn't represent the role well. > ... for decoupling WebFrameImpl ...
7 years, 1 month ago (2013-11-14 01:50:38 UTC) #2
Andrey Kraynov
On 2013/11/14 01:50:38, tkent wrote: > I feel the name 'InFrameFinder' doesn't represent the role ...
7 years ago (2013-11-26 08:53:03 UTC) #3
tkent
> Could I name it WebFrameTextFinder or even WebFrameImplTextFinder to show > that it is ...
7 years ago (2013-11-27 01:24:39 UTC) #4
Andrey Kraynov
On 2013/11/27 01:24:39, tkent wrote: > > Could I name it WebFrameTextFinder or even WebFrameImplTextFinder ...
7 years ago (2013-11-29 13:15:53 UTC) #5
tkent
lgtm
7 years ago (2013-12-01 23:52:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iceman@yandex-team.ru/68263009/40002
7 years ago (2013-12-01 23:52:51 UTC) #7
commit-bot: I haz the power
Change committed as 162937
7 years ago (2013-12-02 01:16:02 UTC) #8
eseidel
These two files are already out of date. Please don't do this.
7 years ago (2013-12-10 21:34:02 UTC) #9
eseidel
Also, please use a BUG so we can track changes between multiple revisions.
7 years ago (2013-12-10 21:34:25 UTC) #10
eseidel
7 years ago (2013-12-10 21:36:18 UTC) #11
Message was sent while issue was closed.
Removing this copy in:
https://codereview.chromium.org/112083002

This came up because I made local changes to that file, not realizing it was
some work-in-progress-patch.

Powered by Google App Engine
This is Rietveld 408576698