Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 68263003: Use SkPathJoin and SkBasename in Pdfviewer. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
Reviewers:
edisonn
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use SkPathJoin and SkBasename in Pdfviewer. Remove redundant code. R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=12240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -57 lines) Patch
M experimental/PdfViewer/pdf_viewer_main.cpp View 4 chunks +3 lines, -57 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
7 years, 1 month ago (2013-11-11 17:54:42 UTC) #1
edisonn
LGTM
7 years, 1 month ago (2013-11-11 17:57:05 UTC) #2
scroggo
7 years, 1 month ago (2013-11-12 14:43:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698