Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/password_manager/native_backend_gnome_x.h

Issue 682613003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_
7 7
8 // libgnome-keyring has been deprecated in favor of libsecret. 8 // libgnome-keyring has been deprecated in favor of libsecret.
9 // See: https://mail.gnome.org/archives/commits-list/2013-October/msg08876.html 9 // See: https://mail.gnome.org/archives/commits-list/2013-October/msg08876.html
10 // 10 //
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 static const FunctionInfo functions[]; 79 static const FunctionInfo functions[];
80 #endif // defined(DLOPEN_GNOME_KEYRING) 80 #endif // defined(DLOPEN_GNOME_KEYRING)
81 }; 81 };
82 82
83 // NativeBackend implementation using GNOME Keyring. 83 // NativeBackend implementation using GNOME Keyring.
84 class NativeBackendGnome : public PasswordStoreX::NativeBackend, 84 class NativeBackendGnome : public PasswordStoreX::NativeBackend,
85 public GnomeKeyringLoader { 85 public GnomeKeyringLoader {
86 public: 86 public:
87 explicit NativeBackendGnome(LocalProfileId id); 87 explicit NativeBackendGnome(LocalProfileId id);
88 88
89 virtual ~NativeBackendGnome(); 89 ~NativeBackendGnome() override;
90 90
91 virtual bool Init() override; 91 bool Init() override;
92 92
93 // Implements NativeBackend interface. 93 // Implements NativeBackend interface.
94 virtual password_manager::PasswordStoreChangeList AddLogin( 94 password_manager::PasswordStoreChangeList AddLogin(
95 const autofill::PasswordForm& form) override; 95 const autofill::PasswordForm& form) override;
96 virtual bool UpdateLogin( 96 bool UpdateLogin(const autofill::PasswordForm& form,
97 const autofill::PasswordForm& form, 97 password_manager::PasswordStoreChangeList* changes) override;
98 password_manager::PasswordStoreChangeList* changes) override; 98 bool RemoveLogin(const autofill::PasswordForm& form) override;
99 virtual bool RemoveLogin(const autofill::PasswordForm& form) override; 99 bool RemoveLoginsCreatedBetween(
100 virtual bool RemoveLoginsCreatedBetween(
101 base::Time delete_begin, 100 base::Time delete_begin,
102 base::Time delete_end, 101 base::Time delete_end,
103 password_manager::PasswordStoreChangeList* changes) override; 102 password_manager::PasswordStoreChangeList* changes) override;
104 virtual bool RemoveLoginsSyncedBetween( 103 bool RemoveLoginsSyncedBetween(
105 base::Time delete_begin, 104 base::Time delete_begin,
106 base::Time delete_end, 105 base::Time delete_end,
107 password_manager::PasswordStoreChangeList* changes) override; 106 password_manager::PasswordStoreChangeList* changes) override;
108 virtual bool GetLogins(const autofill::PasswordForm& form, 107 bool GetLogins(const autofill::PasswordForm& form,
109 PasswordFormList* forms) override; 108 PasswordFormList* forms) override;
110 virtual bool GetAutofillableLogins(PasswordFormList* forms) override; 109 bool GetAutofillableLogins(PasswordFormList* forms) override;
111 virtual bool GetBlacklistLogins(PasswordFormList* forms) override; 110 bool GetBlacklistLogins(PasswordFormList* forms) override;
112 111
113 private: 112 private:
114 enum TimestampToCompare { 113 enum TimestampToCompare {
115 CREATION_TIMESTAMP, 114 CREATION_TIMESTAMP,
116 SYNC_TIMESTAMP, 115 SYNC_TIMESTAMP,
117 }; 116 };
118 117
119 // Adds a login form without checking for one to replace first. 118 // Adds a login form without checking for one to replace first.
120 bool RawAddLogin(const autofill::PasswordForm& form); 119 bool RawAddLogin(const autofill::PasswordForm& form);
121 120
(...skipping 23 matching lines...) Expand all
145 // The local profile id, used to generate the app string. 144 // The local profile id, used to generate the app string.
146 const LocalProfileId profile_id_; 145 const LocalProfileId profile_id_;
147 146
148 // The app string, possibly based on the local profile id. 147 // The app string, possibly based on the local profile id.
149 std::string app_string_; 148 std::string app_string_;
150 149
151 DISALLOW_COPY_AND_ASSIGN(NativeBackendGnome); 150 DISALLOW_COPY_AND_ASSIGN(NativeBackendGnome);
152 }; 151 };
153 152
154 #endif // CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_ 153 #endif // CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698