Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 682603002: remove stray usage of logging_like_official_build (Closed)

Created:
6 years, 1 month ago by Mostyn Bramley-Moore
Modified:
6 years, 1 month ago
Reviewers:
Xianzhu, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove stray usage of logging_like_official_build The logging_like_official_build gyp setting was removed in this CL: https://codereview.chromium.org/189603007 BUG=334021 Committed: https://crrev.com/43a6f9c8185dddfce0cd016964524059175de74b Cr-Commit-Position: refs/heads/master@{#301344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M android_webview/tools/gyp_webview View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mostyn Bramley-Moore
@Torne: PTAL.
6 years, 1 month ago (2014-10-27 08:46:51 UTC) #2
Torne
lgtm
6 years, 1 month ago (2014-10-27 10:42:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682603002/1
6 years, 1 month ago (2014-10-27 10:47:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 11:30:25 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 11:31:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a6f9c8185dddfce0cd016964524059175de74b
Cr-Commit-Position: refs/heads/master@{#301344}

Powered by Google App Engine
This is Rietveld 408576698