Issue 682593002: Use embedded test server instead of spawned one in AllUrlsApiTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682593002: Use embedded test server instead of spawned one in AllUrlsApiTest. (Closed)

Created:
6 years, 1 month ago by mharanczyk

Modified:
6 years, 1 month ago

Reviewers:
Finnur, Yoyo Zhou, asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use embedded test server instead of spawned one in AllUrlsApiTest. This prevents file lock problems on those tests shutdown on windows. BUG=427420 Committed: https://crrev.com/16390930b069582d9476c4d5f07f404ec59720ef Cr-Commit-Position: refs/heads/master@{#301340}

Patch Set 1 #

Patch Set 2 : Line endings.... lets hope it goes well this time. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/extensions/all_urls_apitest.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682593002/20001

6 years, 1 month ago (2014-10-27 10:33:06 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-27 11:18:24 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/16390930b069582d9476c4d5f07f404ec59720ef
Cr-Commit-Position: refs/heads/master@{#301340}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages