tools/skp/page_sets/skia_mobilenews_desktop.py - Issue 682573004: pagesets are still crashing in RecreateSKPs bot, try adding waits to most pagesets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skp/page_sets/skia_mobilenews_desktop.py

Issue 682573004: pagesets are still crashing in RecreateSKPs bot, try adding waits to most pagesets (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/skp/page_sets/skia_mobilenews_desktop.py

diff --git a/tools/skp/page_sets/skia_mobilenews_desktop.py b/tools/skp/page_sets/skia_mobilenews_desktop.py

index e3572779c6d1090cd4888d4c8e656751e09d38fd..50db2e6a81594cf33ee9675472e63ce595be8487 100644

--- a/tools/skp/page_sets/skia_mobilenews_desktop.py

+++ b/tools/skp/page_sets/skia_mobilenews_desktop.py

@@ -18,6 +18,10 @@ class SkiaBuildbotDesktopPage(page_module.Page):

self.user_agent_type = 'desktop'

self.archive_data_file = 'data/skia_mobilenews_desktop.json'

+ def RunNavigateSteps(self, action_runner):

+ action_runner.NavigateToPage(self)

+ action_runner.Wait(5)

class SkiaMobilenewsDesktopPageSet(page_set_module.PageSet):

« no previous file with comments | « tools/skp/page_sets/skia_mlb_nexus10.py ('k') | tools/skp/page_sets/skia_mozilla_nexus10.py » ('j') | no next file with comments »