Issue 682573003: Update DEPS for chromium roll, fix few sky issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682573003: Update DEPS for chromium roll, fix few sky issues (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Update DEPS for chromium roll, fix few sky issues This updates DEPS to match the recent chromium roll and applies the following changes to sky to accomodate the skia roll: https://src.chromium.org/viewvc/blink?revision=184191&view=revision https://src.chromium.org/viewvc/blink?revision=184289&view=revision as well as adding #include <string> to WTFString.h so it compiles for translation units that include this without #including <string> themselves, which currently happens in a number of files in the android build. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7c22edcaf0681aca85a8de9ebf8a016eab13e226

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -9 lines)			Patch
M	DEPS	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/engine/platform/graphics/Canvas2DLayerBridge.cpp	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	sky/engine/wtf/text/WTFString.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

jamesr

Adam - gonna TBR so we don't have misaligned DEPS (I shoulda updated that with ...

6 years, 1 month ago (2014-10-27 06:50:28 UTC) #1

jamesr

Committed patchset #1 (id:1) manually as 7c22edcaf0681aca85a8de9ebf8a016eab13e226 (presubmit successful).

6 years, 1 month ago (2014-10-27 06:50:56 UTC) #2

Message was sent while issue was closed.

LGTM