StyleResolverParentPusher can decide if it needs to push at creation time

StyleResolverParentPusher can decide if it needs to push at creation time

We can decide at creation time if the ParentPusher needs to push a parent
style to the bloom filter instead of having a push() method call inside
of each of the loops during recalcStyle.

I also removed the ASSERT and if statement (with the same check) from inside
the ParentPusher. There's no reason to guard against getting the parent stack
wrong, the stack itself already has guards against it and getting it wrong is
not a security issue (so there's no reason for an ASSERT and duplicate if).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161770

[leviw_travelin_and_unemployed, 2013-11-11 18:56:15]

LGTM.

https://codereview.chromium.org/68253003/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/68253003/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:112: StyleResolverParentPusher(Element& parent,
StyleRecalcChange change = NoChange)
Since the 2nd argument isn't required, are you sure you don't still want the
explicit?

[esprehn, 2013-11-11 19:02:53]

On 2013/11/11 18:56:15, Levi wrote:
> LGTM.
> 
> https://codereview.chromium.org/68253003/diff/1/Source/core/dom/Element.cpp
> File Source/core/dom/Element.cpp (right):
> 
>
https://codereview.chromium.org/68253003/diff/1/Source/core/dom/Element.cpp#n...
> Source/core/dom/Element.cpp:112: StyleResolverParentPusher(Element& parent,
> StyleRecalcChange change = NoChange)
> Since the 2nd argument isn't required, are you sure you don't still want the
> explicit?

Err yeah, good catch.

[commit-bot: I haz the power, 2013-11-11 19:08:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/68253003/60001

[commit-bot: I haz the power, 2013-11-12 06:13:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/68253003/190001

[commit-bot: I haz the power, 2013-11-12 07:16:08]

Change committed as 161770