chrome/browser/resources/new_new_tab.html - Issue 6825052: Update the web store promo to be clearer and configurable at run-time.

Side by Side Diff: chrome/browser/resources/new_new_tab.html

Issue 6825052: Update the web store promo to be clearer and configurable at run-time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix URL. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="	2 <html i18n-values="

3 dir:textdirection;	3 dir:textdirection;

4 bookmarkbarattached:bookmarkbarattached;	4 bookmarkbarattached:bookmarkbarattached;

5 hasattribution:hasattribution;	5 hasattribution:hasattribution;

6 anim:anim;	6 anim:anim;

7 syncispresent:syncispresent;	7 syncispresent:syncispresent;

8 customlogo:customlogo"	8 customlogo:customlogo"

9 install-animation-enabled="true">	9 install-animation-enabled="true">

10 <head>	10 <head>

(...skipping 128 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
139 <button id="notification-close"></button>	139 <button id="notification-close"></button>

140 </div>	140 </div>

141 </div>	141 </div>

142	142

143 <div id="login-container">	143 <div id="login-container">

144 <span id="login-username"></span>	144 <span id="login-username"></span>

145 </div>	145 </div>

146	146

147 <div class="maxiview" id="apps-maxiview">	147 <div class="maxiview" id="apps-maxiview">

148 <div id="apps-promo">	148 <div id="apps-promo">

149 <button id="apps-promo-hide" i18n-content="appspromohide"></button>	149 <p id="apps-promo-heading"></p>

150 <h3 i18n-content="appspromoheader"></h3>	150 <div class="g-button-basic">

151 <p id="apps-promo-text1" i18n-values=".innerHTML:appspromotext1"></p>	151 <div><span><span>
	arv (Not doing code reviews) 2011/04/13 17:17:59 div-span-span? What tag is that? Why do you need div-span-span? What tag is that? Why do you need these and why isn't a plain <a> enough? jstritar 2011/04/13 19:52:27 I asked myself the same question. I'm using the bu Show quoted text On 2011/04/13 17:17:59, arv wrote: > div-span-span? What tag is that? > > Why do you need these and why isn't a plain <a> enough? I asked myself the same question. I'm using the buttons from go/buttons. I'm not sure its worth modifying them much, since I'd like to make it easy to port changes in them back to Chrome.
152 <p id="apps-promo-text2" i18n-content="appspromotext2"></p>	152 <a id="apps-promo-link" href=""></a>

	153 </span></span></div>

	154 </div>

	155 <button id="apps-promo-hide"></button>

153 </div>	156 </div>

154 <div id="apps-content"></div>	157 <div id="apps-content"></div>

155 </div>	158 </div>

156 <div class="maxiview" id="most-visited-maxiview"></div>	159 <div class="maxiview" id="most-visited-maxiview"></div>

157	160

158 <div class="sections">	161 <div class="sections">

159 <!-- Start disabled. We only enable once we have installed default apps. -->	162 <!-- Start disabled. We only enable once we have installed default apps. -->

160 <div id="apps" class="section disabled" section="APPS">	163 <div id="apps" class="section disabled" section="APPS">

161 <h2>	164 <h2>

162 <img class="disclosure" img src="ntp/ntp_disclosure_triangle.png">	165 <img class="disclosure" img src="ntp/ntp_disclosure_triangle.png">

(...skipping 152 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
315 var recentlyClosedInitiallyMenu = shownSections & MENU_RECENT;	318 var recentlyClosedInitiallyMenu = shownSections & MENU_RECENT;

316 setSectionMenuMode('apps', Section.APPS, appsInitiallyMenu, MENU_APPS);	319 setSectionMenuMode('apps', Section.APPS, appsInitiallyMenu, MENU_APPS);

317 setSectionMenuMode('most-visited', Section.THUMB, mostVisitedInitiallyMenu,	320 setSectionMenuMode('most-visited', Section.THUMB, mostVisitedInitiallyMenu,

318 MENU_THUMB);	321 MENU_THUMB);

319 setSectionMenuMode('recently-closed', undefined, recentlyClosedInitiallyMenu,	322 setSectionMenuMode('recently-closed', undefined, recentlyClosedInitiallyMenu,

320 MENU_RECENT);	323 MENU_RECENT);

321	324

322 layoutSections();	325 layoutSections();

323 </script>	326 </script>

324 </html>	327 </html>

OLD	NEW