Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 682493002: Remove the dependency on json schema compiler. (Closed)

Created:
6 years, 1 month ago by yzshen1
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove the dependency on json schema compiler. BUG=None TEST=None R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/15b9d4ab8e037e35fafa88c70fbfd239cfa19c48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15297 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M PRESUBMIT.py View 3 chunks +1 line, -29 lines 0 comments Download
D build/json_schema_api.gni View 1 chunk +0 lines, -209 lines 0 comments Download
D build/json_schema_bundle_compile.gypi View 1 chunk +0 lines, -83 lines 0 comments Download
D build/json_schema_bundle_registration_compile.gypi View 1 chunk +0 lines, -78 lines 0 comments Download
D build/json_schema_compile.gypi View 1 chunk +0 lines, -123 lines 0 comments Download
D build/json_to_struct.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
M mojo/tools/roll/rev.py View 1 chunk +0 lines, -1 line 0 comments Download
D tools/json_schema_compiler/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/json_schema_compiler/PRESUBMIT.py View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/json_schema_compiler/api_gen_util.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/json_schema_compiler/cc_generator.py View 1 chunk +0 lines, -1070 lines 0 comments Download
D tools/json_schema_compiler/code.py View 1 chunk +0 lines, -142 lines 0 comments Download
D tools/json_schema_compiler/code_test.py View 1 chunk +0 lines, -165 lines 0 comments Download
D tools/json_schema_compiler/compiler.py View 1 chunk +0 lines, -198 lines 0 comments Download
D tools/json_schema_compiler/cpp_bundle_generator.py View 1 chunk +0 lines, -322 lines 0 comments Download
D tools/json_schema_compiler/cpp_generator.py View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/json_schema_compiler/cpp_namespace_environment.py View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/json_schema_compiler/cpp_type_generator.py View 1 chunk +0 lines, -273 lines 0 comments Download
D tools/json_schema_compiler/cpp_type_generator_test.py View 1 chunk +0 lines, -193 lines 0 comments Download
D tools/json_schema_compiler/cpp_util.py View 1 chunk +0 lines, -158 lines 0 comments Download
D tools/json_schema_compiler/cpp_util_test.py View 1 chunk +0 lines, -63 lines 0 comments Download
D tools/json_schema_compiler/dart_generator.py View 1 chunk +0 lines, -763 lines 0 comments Download
D tools/json_schema_compiler/dart_generator_test.py View 1 chunk +0 lines, -81 lines 0 comments Download
D tools/json_schema_compiler/dart_test/comments.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/json_schema_compiler/dart_test/comments.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/json_schema_compiler/dart_test/dictionaries.dart View 1 chunk +0 lines, -235 lines 0 comments Download
D tools/json_schema_compiler/dart_test/dictionaries.idl View 1 chunk +0 lines, -61 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_namespace.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_namespace.idl View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_type.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_type.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/json_schema_compiler/dart_test/events.dart View 1 chunk +0 lines, -282 lines 0 comments Download
D tools/json_schema_compiler/dart_test/events.idl View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/json_schema_compiler/dart_test/functions.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D tools/json_schema_compiler/dart_test/functions.idl View 1 chunk +0 lines, -55 lines 0 comments Download
D tools/json_schema_compiler/dart_test/operatable_type.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tools/json_schema_compiler/dart_test/operatable_type.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/json_schema_compiler/dart_test/tags.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D tools/json_schema_compiler/dart_test/tags.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/json_schema_compiler/features_cc_generator.py View 1 chunk +0 lines, -95 lines 0 comments Download
D tools/json_schema_compiler/features_compiler.py View 1 chunk +0 lines, -76 lines 0 comments Download
D tools/json_schema_compiler/features_h_generator.py View 1 chunk +0 lines, -99 lines 0 comments Download
D tools/json_schema_compiler/h_generator.py View 1 chunk +0 lines, -397 lines 0 comments Download
D tools/json_schema_compiler/highlighters/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/json_schema_compiler/highlighters/hilite_me_highlighter.py View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/json_schema_compiler/highlighters/none_highlighter.py View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/json_schema_compiler/highlighters/pygments_highlighter.py View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/json_schema_compiler/idl_schema.py View 1 chunk +0 lines, -488 lines 0 comments Download
D tools/json_schema_compiler/idl_schema_test.py View 1 chunk +0 lines, -396 lines 0 comments Download
D tools/json_schema_compiler/json_parse.py View 1 chunk +0 lines, -61 lines 0 comments Download
D tools/json_schema_compiler/json_schema.py View 1 chunk +0 lines, -57 lines 0 comments Download
D tools/json_schema_compiler/json_schema_test.py View 1 chunk +0 lines, -99 lines 0 comments Download
D tools/json_schema_compiler/memoize.py View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/json_schema_compiler/model.py View 1 chunk +0 lines, -605 lines 0 comments Download
D tools/json_schema_compiler/model_test.py View 1 chunk +0 lines, -147 lines 0 comments Download
D tools/json_schema_compiler/preview.py View 1 chunk +0 lines, -364 lines 0 comments Download
D tools/json_schema_compiler/schema_loader.py View 1 chunk +0 lines, -92 lines 0 comments Download
D tools/json_schema_compiler/schema_util.py View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/json_schema_compiler/schema_util_test.py View 1 chunk +0 lines, -25 lines 0 comments Download
D tools/json_schema_compiler/test/additional_properties.json View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/json_schema_compiler/test/additional_properties_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D tools/json_schema_compiler/test/any.json View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/json_schema_compiler/test/any_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D tools/json_schema_compiler/test/arrays.json View 1 chunk +0 lines, -274 lines 0 comments Download
D tools/json_schema_compiler/test/arrays_unittest.cc View 1 chunk +0 lines, -317 lines 0 comments Download
D tools/json_schema_compiler/test/browser_action.json View 1 chunk +0 lines, -273 lines 0 comments Download
D tools/json_schema_compiler/test/callbacks.json View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/json_schema_compiler/test/callbacks_unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/json_schema_compiler/test/choices.json View 1 chunk +0 lines, -167 lines 0 comments Download
D tools/json_schema_compiler/test/choices_unittest.cc View 1 chunk +0 lines, -292 lines 0 comments Download
D tools/json_schema_compiler/test/content_settings.json View 1 chunk +0 lines, -222 lines 0 comments Download
D tools/json_schema_compiler/test/crossref.json View 1 chunk +0 lines, -76 lines 0 comments Download
D tools/json_schema_compiler/test/crossref_unittest.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D tools/json_schema_compiler/test/dependency_tester.json View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/json_schema_compiler/test/enums.json View 1 chunk +0 lines, -265 lines 0 comments Download
D tools/json_schema_compiler/test/enums_unittest.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D tools/json_schema_compiler/test/error_generation.json View 1 chunk +0 lines, -152 lines 0 comments Download
D tools/json_schema_compiler/test/error_generation_unittest.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D tools/json_schema_compiler/test/features_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/json_schema_compiler/test/font_settings.json View 1 chunk +0 lines, -551 lines 0 comments Download
D tools/json_schema_compiler/test/forbidden.json View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/json_schema_compiler/test/functions_as_parameters.json View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/json_schema_compiler/test/functions_as_parameters_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D tools/json_schema_compiler/test/functions_on_types.json View 1 chunk +0 lines, -75 lines 0 comments Download
D tools/json_schema_compiler/test/functions_on_types_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/json_schema_compiler/test/idl_basics.idl View 1 chunk +0 lines, -106 lines 0 comments Download
D tools/json_schema_compiler/test/idl_function_types.idl View 1 chunk +0 lines, -18 lines 0 comments Download
D tools/json_schema_compiler/test/idl_namespace_all_platforms.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/json_schema_compiler/test/idl_namespace_chromeos.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/json_schema_compiler/test/idl_namespace_non_specific_platforms.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/json_schema_compiler/test/idl_namespace_specific_implement.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/json_schema_compiler/test/idl_namespace_specific_implement_chromeos.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/json_schema_compiler/test/idl_object_types.idl View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/json_schema_compiler/test/idl_other_namespace.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/json_schema_compiler/test/idl_other_namespace_sub_namespace.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/json_schema_compiler/test/idl_reserved_words.idl View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/json_schema_compiler/test/idl_schemas_unittest.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D tools/json_schema_compiler/test/json_schema_compiler_tests.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D tools/json_schema_compiler/test/json_schema_test.json View 1 chunk +0 lines, -106 lines 0 comments Download
D tools/json_schema_compiler/test/objects.json View 1 chunk +0 lines, -140 lines 0 comments Download
D tools/json_schema_compiler/test/objects_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/json_schema_compiler/test/permissions.json View 1 chunk +0 lines, -140 lines 0 comments Download
D tools/json_schema_compiler/test/simple_api.json View 1 chunk +0 lines, -163 lines 0 comments Download
D tools/json_schema_compiler/test/simple_api_unittest.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D tools/json_schema_compiler/test/tabs.json View 1 chunk +0 lines, -770 lines 0 comments Download
D tools/json_schema_compiler/test/test_features.json View 1 chunk +0 lines, -25 lines 0 comments Download
D tools/json_schema_compiler/test/test_util.h View 1 chunk +0 lines, -55 lines 0 comments Download
D tools/json_schema_compiler/test/test_util.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D tools/json_schema_compiler/test/windows.json View 1 chunk +0 lines, -265 lines 0 comments Download
D tools/json_schema_compiler/util.h View 1 chunk +0 lines, -181 lines 0 comments Download
D tools/json_schema_compiler/util.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D tools/json_schema_compiler/util_cc_helper.py View 1 chunk +0 lines, -75 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
yzshen1
Hi, James. Please take a look.Thanks! This change triggered a warning that PRESUBMIT_test.py is not ...
6 years, 1 month ago (2014-10-26 04:11:21 UTC) #2
jamesr
lgtm looks like we should import PRESUBMIT_test.py from the chromium repo and make it pass ...
6 years, 1 month ago (2014-10-27 05:14:47 UTC) #3
yzshen1
Committed patchset #1 (id:1) manually as 15b9d4ab8e037e35fafa88c70fbfd239cfa19c48 (presubmit successful).
6 years, 1 month ago (2014-10-27 05:46:36 UTC) #4
yzshen1
6 years, 1 month ago (2014-10-27 05:47:07 UTC) #5
Message was sent while issue was closed.
On 2014/10/27 05:14:47, jamesr wrote:
> lgtm
> 
> looks like we should import PRESUBMIT_test.py from the chromium repo and make
it
> pass in our world.  Would you mind taking a crack at that in a separate CL? 
> Thanks.

Sure. I will do that. Thanks!

Powered by Google App Engine
This is Rietveld 408576698