Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 682463002: Revert "Sync wallpaper based on sync themes setting" (Closed)

Created:
6 years, 1 month ago by Avi (use Gerrit)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Sync wallpaper based on sync themes setting" This reverts commit af3c28a48df70525b927813b08b27407f4138fe0. TBR=scheib@chromium.org,cpu@chromium.org,jar@chromium.org,bshe@chromium.org NOTREECHECKS=true NOTRY=true BUG=236640 Committed: https://crrev.com/776de5c23c22bf71859e3f73cf2635f40ba01164 Cr-Commit-Position: refs/heads/master@{#301288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -153 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js View 1 chunk +64 lines, -68 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/util.js View 5 chunks +11 lines, -25 lines 0 comments Download
M chrome/common/extensions/api/wallpaper_private.json View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/test/data/chromeos/wallpaper_manager/unit_tests/api_mock.js View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Avi (use Gerrit)
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1) started consistently failing OptionsWebUIExtendedTest.CloseOverlay in the build in which this was the only CL. ...
6 years, 1 month ago (2014-10-25 18:14:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682463002/1
6 years, 1 month ago (2014-10-25 18:15:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-25 18:16:02 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/776de5c23c22bf71859e3f73cf2635f40ba01164 Cr-Commit-Position: refs/heads/master@{#301288}
6 years, 1 month ago (2014-10-25 18:16:47 UTC) #5
Avi (use Gerrit)
6 years, 1 month ago (2014-10-25 18:18:49 UTC) #6
Message was sent while issue was closed. 
On 2014/10/25 18:16:47, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/776de5c23c22bf71859e3f73cf2635f40ba01164
> Cr-Commit-Position: refs/heads/master@{#301288}

BTW, I think this is probably innocent now that I've found a different suspect.
Reland if you want.

Powered by Google App Engine
This is Rietveld 408576698