Issue 68243006: Use HashCountedSet for fontStats in InspectorCSSAgent

Issue 68243006: Use HashCountedSet for fontStats in InspectorCSSAgent (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
pfeldman, eseidel

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use HashCountedSet for fontStats in InspectorCSSAgent Use HashCountedSet for fontStats in InspectorCSSAgent instead of handling the counting manually and using a HashMap data structure. This makes the code a bit simpler. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161837

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	Source/core/inspector/InspectorCSSAgent.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	Source/core/inspector/InspectorCSSAgent.cpp	View		4 chunks	+4 lines, -5 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/68243006/1

7 years, 1 month ago (2013-11-11 22:21:37 UTC) #4

Inactive

https://codereview.chromium.org/68243006/diff/1/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/68243006/diff/1/Source/core/inspector/InspectorCSSAgent.cpp#newcode1086 Source/core/inspector/InspectorCSSAgent.cpp:1086: .setFamilyName(it->key) The values are read in this loop.

7 years, 1 month ago (2013-11-11 22:50:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/68243006/1

7 years, 1 month ago (2013-11-12 17:41:44 UTC) #6

Message was sent while issue was closed.

Change committed as 161837

Expand Messages | Collapse Messages