Issue 68243003: Revert 234194 "Add support for datalist to text input element on..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68243003: Revert 234194 "Add support for datalist to text input element on..." (Closed)

Created:
7 years, 1 month ago by keishi

Modified:
7 years, 1 month ago

Reviewers:
keishi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 234194 "Add support for datalist to text input element on..." > Add support for datalist to text input element on Android > > We want to have a darker color divider between the datalist suggestions and autofill suggestions. > > The ListView instance is constructed inside ListPopupWindow so we can't override ListView.drawDivider(), so we draw the divider inside the list item view. > > BUG=242455 > > Review URL: https://codereview.chromium.org/23314003 TBR=keishi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234203

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -136 lines)			Patch
M	trunk/src/ui/android/java/res/layout/autofill_text.xml	View	1 chunk	+25 lines, -23 lines	0 comments	Download
M	trunk/src/ui/android/java/res/values/colors.xml	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ui/android/java/res/values/dimens.xml	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ui/android/java/resource_map/org/chromium/ui/R.java	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	trunk/src/ui/android/java/src/org/chromium/ui/autofill/AutofillDividerDrawable.java	View	1 chunk	+0 lines, -55 lines	0 comments	Download
M	trunk/src/ui/android/java/src/org/chromium/ui/autofill/AutofillListAdapter.java	View	3 chunks	+2 lines, -32 lines	0 comments	Download
M	trunk/src/ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java	View	6 chunks	+3 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r234203.

Expand Messages | Collapse Messages