Issue 68243002: ash: Rename LauncherModelObserver to ShelfModelObserver.

Issue 68243002: ash: Rename LauncherModelObserver to ShelfModelObserver. (Closed)

Created:
7 years, 1 month ago by tfarina

Modified:
7 years, 1 month ago

Reviewers:
Harry McCleave, James Cook, sky

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ash: Rename LauncherModelObserver to ShelfModelObserver. - move launcher_model_observer.h from launcher/ to shelf/ - rename to shelf_model_observer.h BUG=248353 TEST=None, no functional changes R=harrym@chromium.org,jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234686

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -149 lines)			Patch
M	ash/ash.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	ash/launcher/launcher_item_delegate_manager.h	View	3 chunks	+9 lines, -11 lines	0 comments	Download
M	ash/launcher/launcher_item_delegate_manager.cc	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	ash/launcher/launcher_model.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/launcher/launcher_model.cc	View	6 chunks	+11 lines, -13 lines	0 comments	Download
D	ash/launcher/launcher_model_observer.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	ash/launcher/launcher_model_unittest.cc	View	6 chunks	+14 lines, -14 lines	0 comments	Download
A +	ash/shelf/shelf_model_observer.h	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	ash/shelf/shelf_view.h	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	ash/shelf/shelf_view.cc	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.h	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc	View	5 chunks	+15 lines, -15 lines	0 comments	Download

Total messages: 8 (0 generated)

tfarina

Harry, James ping? Looping Scott for OWNERS approval though. Thanks!

7 years, 1 month ago (2013-11-12 13:30:01 UTC) #2

Harry McCleave

On 2013/11/12 13:30:01, tfarina wrote: > Harry, James ping? > > Looping Scott for OWNERS ...

7 years, 1 month ago (2013-11-12 18:23:00 UTC) #3

James Cook

LGTM, but are you going to move launcher_model.h/cc soon? It seems strange to have the ...

7 years, 1 month ago (2013-11-12 18:29:07 UTC) #4

tfarina

On 2013/11/12 18:29:07, James Cook wrote: > LGTM, but are you going to move launcher_model.h/cc ...

7 years, 1 month ago (2013-11-12 18:37:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/68243002/1

7 years, 1 month ago (2013-11-12 18:38:12 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/68243002/1

7 years, 1 month ago (2013-11-12 23:48:54 UTC) #7

Message was sent while issue was closed.

Change committed as 234686