Source/core/inspector/InspectorAnimationAgent.h - Issue 682423002: Devtools Animations: Show subtree animations for a given node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorAnimationAgent.h

Issue 682423002: Devtools Animations: Show subtree animations for a given node (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review changes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/Animation.h ('k') | Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | Source/devtools/front_end/common/Settings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorAnimationAgent.h

diff --git a/Source/core/inspector/InspectorAnimationAgent.h b/Source/core/inspector/InspectorAnimationAgent.h

index e34efdb9a40328d9491b9b0aa8d8c60f500a2209..0a299535b169421b853d8dc220b9cf240584a70c 100644

--- a/Source/core/inspector/InspectorAnimationAgent.h

+++ b/Source/core/inspector/InspectorAnimationAgent.h

@@ -34,7 +34,7 @@ public:

void reset();

// Protocol method implementations.

- virtual void getAnimationPlayersForNode(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationPlayer> >& animationPlayersArray) override;

+ virtual void getAnimationPlayersForNode(ErrorString*, int nodeId, bool includeSubtreeAnimations, RefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationPlayer> >& animationPlayersArray) override;

virtual void pauseAnimationPlayer(ErrorString*, const String& id, RefPtr<TypeBuilder::Animation::AnimationPlayer>&) override;

virtual void playAnimationPlayer(ErrorString*, const String& id, RefPtr<TypeBuilder::Animation::AnimationPlayer>&) override;

virtual void setAnimationPlayerCurrentTime(ErrorString*, const String& id, double currentTime, RefPtr<TypeBuilder::Animation::AnimationPlayer>&) override;

@@ -48,6 +48,10 @@ public:

private:

InspectorAnimationAgent(InspectorDOMAgent*);

+ PassRefPtr<TypeBuilder::Animation::AnimationNode> buildObjectForAnimationNode(AnimationNode*);

+ PassRefPtr<TypeBuilder::Animation::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&, PassRefPtr<TypeBuilder::Animation::KeyframesRule> keyframeRule = nullptr);

+ PassRefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationPlayer> > buildArrayForAnimationPlayers(Element&, const WillBeHeapVector<RefPtrWillBeMember<AnimationPlayer> >);

RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;

InspectorFrontend::Animation* m_frontend;

WillBeHeapHashMap<String, RefPtrWillBeMember<AnimationPlayer> > m_idToAnimationPlayer;

« no previous file with comments | « Source/core/animation/Animation.h ('k') | Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | Source/devtools/front_end/common/Settings.js » ('J')