Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: sky/engine/core/loader/FrameLoaderClient.h

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rm RemoteFrame Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/loader/EmptyClients.h ('k') | sky/engine/core/rendering/RenderRemote.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/loader/FrameLoaderClient.h
diff --git a/sky/engine/core/loader/FrameLoaderClient.h b/sky/engine/core/loader/FrameLoaderClient.h
index ebce8059db8a786a1cb78f9b81fdf69745896bb3..3d041828ccf2acaa5dbc29d415cf35f6d3bca612 100644
--- a/sky/engine/core/loader/FrameLoaderClient.h
+++ b/sky/engine/core/loader/FrameLoaderClient.h
@@ -39,6 +39,10 @@
#include "wtf/Vector.h"
#include <v8.h>
+namespace mojo {
+ class View;
abarth-chromium 2014/11/10 23:47:41 Don't indent pls. (The rest of the file is wrong
+}
+
namespace blink {
class Color;
@@ -49,10 +53,12 @@ namespace blink {
class FetchRequest;
class FrameLoader;
class FrameNetworkingContext;
+ class IntRect;
class IntSize;
class KURL;
class LocalFrame;
class Page;
+ class RemoteFrame;
class ResourceError;
class ResourceHandle;
class ResourceRequest;
@@ -87,8 +93,7 @@ namespace blink {
virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& suggestedName = String()) = 0;
- // TODO(mpcomplete): return surface ID?
- virtual void createView(const KURL&) = 0;
+ virtual mojo::View* createChildFrame(const KURL&) = 0;
// Transmits the change in the set of watched CSS selectors property
// that match any element on the frame.
« no previous file with comments | « sky/engine/core/loader/EmptyClients.h ('k') | sky/engine/core/rendering/RenderRemote.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698