Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: sky/engine/web/FrameLoaderClientImpl.cpp

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/web/FrameLoaderClientImpl.cpp
diff --git a/sky/engine/web/FrameLoaderClientImpl.cpp b/sky/engine/web/FrameLoaderClientImpl.cpp
index 8ea66d9d6188d4de5fb002dc7b882d8129e8b536..f899bf6df8f5dcbd138817243a211101f5a0f8fe 100644
--- a/sky/engine/web/FrameLoaderClientImpl.cpp
+++ b/sky/engine/web/FrameLoaderClientImpl.cpp
@@ -36,6 +36,7 @@
#include "core/dom/Document.h"
#include "core/events/MouseEvent.h"
#include "core/frame/FrameView.h"
+#include "core/frame/RemoteFrame.h"
#include "core/frame/Settings.h"
#include "core/html/HTMLIFrameElement.h"
#include "core/page/Chrome.h"
@@ -250,11 +251,14 @@ void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na
}
}
-void FrameLoaderClientImpl::createView(const KURL& url)
+PassOwnPtr<RemoteFrame> FrameLoaderClientImpl::createChildFrame(const KURL& url)
{
if (m_webFrame->client()) {
- m_webFrame->client()->createChildView(url);
+ mojo::View* child = m_webFrame->client()->createChildFrame(url);
+ return adoptPtr(new RemoteFrame(child));
}
+ ASSERT_NOT_REACHED();
+ return nullptr;
}
void FrameLoaderClientImpl::selectorMatchChanged(const Vector<String>& addedSelectors, const Vector<String>& removedSelectors)

Powered by Google App Engine
This is Rietveld 408576698