Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index 0885e331baf4509eb03eb9383c730ac4eba7c830..e0a83fa2a84a713b84c3441cc30b4b7088bc6897 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -7,6 +7,7 @@
#include "core/HTMLNames.h"
#include "core/frame/LocalFrame.h"
+#include "core/frame/RemoteFrame.h"
#include "core/html/parser/HTMLParserIdioms.h"
#include "core/loader/FrameLoaderClient.h"
#include "core/rendering/RenderRemote.h"
@@ -19,7 +20,8 @@ PassRefPtr<HTMLIFrameElement> HTMLIFrameElement::create(Document& document)
}
HTMLIFrameElement::HTMLIFrameElement(Document& document)
- : HTMLElement(HTMLNames::iframeTag, document)
+ : HTMLElement(HTMLNames::iframeTag, document),
+ m_contentFrame(nullptr)
abarth-chromium 2014/11/10 23:03:51 No need for this. OwnPtr does it automatically.
{
}
@@ -59,7 +61,7 @@ void HTMLIFrameElement::createView()
return;
KURL url = document().completeURL(urlString);
- parentFrame->loaderClient()->createView(url);
+ m_contentFrame = parentFrame->loaderClient()->createChildFrame(url);
}
}

Powered by Google App Engine
This is Rietveld 408576698