Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: sky/viewer/document_view.cc

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: indent Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/viewer/document_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/document_view.cc
diff --git a/sky/viewer/document_view.cc b/sky/viewer/document_view.cc
index d34d253f8fe835b3e97aefccbe67a43e5ea38374..1d9bdea793bd2585e4d86acfabacb75e44c8212f 100644
--- a/sky/viewer/document_view.cc
+++ b/sky/viewer/document_view.cc
@@ -151,20 +151,15 @@ blink::WebLayerTreeView* DocumentView::initializeLayerTreeView() {
return web_layer_tree_view_impl_.get();
}
-void DocumentView::createChildView(const blink::WebURL& url) {
+mojo::View* DocumentView::createChildFrame(const blink::WebURL& url) {
if (!root_)
- return;
+ return nullptr;
mojo::View* child = mojo::View::Create(root_->view_manager());
root_->AddChild(child);
- // TODO(mpcomplete): actual bounds.
- mojo::Rect mojo_bounds;
- mojo_bounds.x = 0;
- mojo_bounds.y = 50;
- mojo_bounds.width = 300;
- mojo_bounds.height = 100;
- child->SetBounds(mojo_bounds);
child->Embed(mojo::String::From(url.string().utf8()));
+
+ return child;
}
void DocumentView::frameDetached(blink::WebFrame* frame) {
« no previous file with comments | « sky/viewer/document_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698