Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: sky/engine/web/FrameLoaderClientImpl.cpp

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: indent Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/web/FrameLoaderClientImpl.h ('k') | sky/viewer/document_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/web/FrameLoaderClientImpl.cpp
diff --git a/sky/engine/web/FrameLoaderClientImpl.cpp b/sky/engine/web/FrameLoaderClientImpl.cpp
index 8ea66d9d6188d4de5fb002dc7b882d8129e8b536..764bc9eed6ba52d4339ad214b5f12dff937367d5 100644
--- a/sky/engine/web/FrameLoaderClientImpl.cpp
+++ b/sky/engine/web/FrameLoaderClientImpl.cpp
@@ -250,11 +250,13 @@ void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na
}
}
-void FrameLoaderClientImpl::createView(const KURL& url)
+mojo::View* FrameLoaderClientImpl::createChildFrame(const KURL& url)
{
if (m_webFrame->client()) {
- m_webFrame->client()->createChildView(url);
+ return m_webFrame->client()->createChildFrame(url);
}
+ ASSERT_NOT_REACHED();
+ return nullptr;
}
void FrameLoaderClientImpl::selectorMatchChanged(const Vector<String>& addedSelectors, const Vector<String>& removedSelectors)
« no previous file with comments | « sky/engine/web/FrameLoaderClientImpl.h ('k') | sky/viewer/document_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698