Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: sky/engine/public/web/WebFrameClient.h

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: indent Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderRemote.cpp ('k') | sky/engine/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/public/web/WebFrameClient.h
diff --git a/sky/engine/public/web/WebFrameClient.h b/sky/engine/public/web/WebFrameClient.h
index 84eb58630d369e22161a825bb0faa9a4bac6c55c..baea883a5236097618083846a2fadf199d077007 100644
--- a/sky/engine/public/web/WebFrameClient.h
+++ b/sky/engine/public/web/WebFrameClient.h
@@ -41,6 +41,10 @@
#include "public/platform/WebURLRequest.h"
#include <v8.h>
+namespace mojo {
+class View;
+}
+
namespace blink {
class WebCachedURLRequest;
@@ -65,11 +69,10 @@ public:
// until frameDetached() is called on it.
// Note: If you override this, you should almost certainly be overriding
// frameDetached().
- virtual WebFrame* createChildFrame(WebLocalFrame* parent, const WebString& frameName) { return 0; }
-
- virtual void createChildView(const WebURL& url) { }
+ virtual mojo::View* createChildFrame(const WebURL& url) { return nullptr; }
// This frame has been detached from the view, but has not been closed yet.
+ // TODO(mpcomplete): reuse these.
virtual void frameDetached(WebFrame*) { }
// This frame has become focused..
@@ -239,9 +242,6 @@ public:
// process. See http://crbug.com/339659.
virtual void forwardInputEvent(const WebInputEvent*) { }
- // Send initial drawing parameters to a child frame that is being rendered out of process.
- virtual void initializeChildFrame(const WebRect& frameRect, float scaleFactor) { }
-
protected:
virtual ~WebFrameClient() { }
};
« no previous file with comments | « sky/engine/core/rendering/RenderRemote.cpp ('k') | sky/engine/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698