Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2947)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 682413006: Add a separate call to initialize the bounds for a sky <iframe> element. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: indent Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/html/HTMLIFrameElement.h ('k') | sky/engine/core/loader/EmptyClients.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index 0885e331baf4509eb03eb9383c730ac4eba7c830..8e98d5407a02831b480ed32d3a8e8f288a3ad9e2 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -19,7 +19,8 @@ PassRefPtr<HTMLIFrameElement> HTMLIFrameElement::create(Document& document)
}
HTMLIFrameElement::HTMLIFrameElement(Document& document)
- : HTMLElement(HTMLNames::iframeTag, document)
+ : HTMLElement(HTMLNames::iframeTag, document),
+ m_contentView(nullptr)
{
}
@@ -48,6 +49,12 @@ RenderObject* HTMLIFrameElement::createRenderer(RenderStyle* style)
return new RenderRemote(this);
}
+void HTMLIFrameElement::OnViewDestroyed(mojo::View* view)
+{
+ DCHECK_EQ(view, m_contentView);
+ m_contentView = nullptr;
+}
+
void HTMLIFrameElement::createView()
{
String urlString = stripLeadingAndTrailingHTMLSpaces(getAttribute(HTMLNames::srcAttr));
@@ -59,7 +66,7 @@ void HTMLIFrameElement::createView()
return;
KURL url = document().completeURL(urlString);
- parentFrame->loaderClient()->createView(url);
+ m_contentView = parentFrame->loaderClient()->createChildFrame(url);
}
}
« no previous file with comments | « sky/engine/core/html/HTMLIFrameElement.h ('k') | sky/engine/core/loader/EmptyClients.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698