Add a separate call to initialize the bounds for a sky <iframe> element.

sky/viewer/document_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/viewer/document_view.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 133 matching lines @@
   shell_->ConnectToApplication("mojo:native_viewport_service",
                                mojo::GetProxy(&gpu_service_provider));
   mojo::InterfacePtr<mojo::Gpu> gpu_service;
   mojo::ConnectToService(gpu_service_provider.get(), &gpu_service);
   web_layer_tree_view_impl_.reset(new WebLayerTreeViewImpl(
       compositor_thread_, surfaces_service.Pass(), gpu_service.Pass()));
 
   return web_layer_tree_view_impl_.get();
 }
 
-void DocumentView::createChildView(const blink::WebURL& url) {
+uint32_t DocumentView::createChildFrame(const blink::WebURL& url) {
   if (!root_)
-    return;
+    return static_cast<uint32_t>(-1);

[esprehn, 2014/11/07 21:22:15]

It seems wrong to continuously cast -1 to a uint for the invalid id. Should
there be a constant for this?

[Matt Perry, 2014/11/10 23:00:56]

Switched to using objects instead of IDs.

 
   mojo::View* child = mojo::View::Create(root_->view_manager());
   root_->AddChild(child);
-  // TODO(mpcomplete): actual bounds.
+  child->Embed(mojo::String::From(url.string().utf8()));
+
+  return child->id();

[abarth-chromium, 2014/11/07 21:25:50]

Why not just return |child| from this function?  Then RenderRemote can call
mojo::View::SetBounds directly.  We'll need to be careful with lifetime to make
sure we cut the connection between HTMLIFrameElement and this mojo::View when
the Document detaches from the Frame, but that should be doable.

[Matt Perry, 2014/11/10 23:00:56]

I wasn't sure about the layering rules, but that's definitely easier.

+}
+
+void DocumentView::initializeChildFrame(uint32_t frame_id, const blink::WebRect& bounds) {
+  if (!root_)
+    return;
+  mojo::View* child = root_->GetChildById(frame_id);
+  if (!child)
+    return;
+
   mojo::Rect mojo_bounds;
-  mojo_bounds.x = 0;
-  mojo_bounds.y = 50;
-  mojo_bounds.width = 300;
-  mojo_bounds.height = 100;
+  mojo_bounds.x = bounds.x;
+  mojo_bounds.y = bounds.y;
+  mojo_bounds.width = bounds.width;
+  mojo_bounds.height = bounds.height;
   child->SetBounds(mojo_bounds);
-  child->Embed(mojo::String::From(url.string().utf8()));
 }
 
 void DocumentView::frameDetached(blink::WebFrame* frame) {
   // |frame| is invalid after here.
   frame->close();
 }
 
 blink::WebNavigationPolicy DocumentView::decidePolicyForNavigation(
     const blink::WebFrameClient::NavigationPolicyInfo& info) {
 
@@ skipping 53 matching lines @@
 
 void DocumentView::OnViewInputEvent(
     mojo::View* view, const mojo::EventPtr& event) {
   scoped_ptr<blink::WebInputEvent> web_event =
       event.To<scoped_ptr<blink::WebInputEvent> >();
   if (web_event)
     web_view_->handleInputEvent(*web_event);
 }
 
 }  // namespace sky