Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 6824081: Add a stub for allocating parameter maps. (Closed)

Created:
9 years, 8 months ago by rossberg
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add a stub for allocating parameter maps. TODO: - Two remaining test case failures that Kevin will look into: * One due to an UNIMPLEMENTED. * One assertion failure in debug/serdes_ExternalWrap__nocrankshaft that I don't quite understand. - x64 and ARM backends. Committed: http://code.google.com/p/v8/source/detail?r=7960

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 14

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -94 lines) Patch
M src/bootstrapper.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 3 2 chunks +5 lines, -15 lines 0 comments Download
M src/codegen.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 2 chunks +304 lines, -72 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rossberg
9 years, 8 months ago (2011-04-20 11:10:33 UTC) #1
fschneider
redirecting to Kevin.
9 years, 8 months ago (2011-04-27 08:38:02 UTC) #2
Kevin Millikin (Chromium)
LGTM. Feel free to treat the comments below as TODO's (i.e., commit this and you ...
9 years, 8 months ago (2011-04-27 11:49:28 UTC) #3
rossberg
PTAL. I did some of the easier modifications you proposed. http://codereview.chromium.org/6824081/diff/11001/src/code-stubs.h File src/code-stubs.h (right): http://codereview.chromium.org/6824081/diff/11001/src/code-stubs.h#newcode690 ...
9 years, 8 months ago (2011-04-27 23:18:00 UTC) #4
Kevin Millikin (Chromium)
LGTM, go ahead and land it.
9 years, 7 months ago (2011-05-19 08:18:58 UTC) #5
Kevin Millikin (Chromium)
9 years, 7 months ago (2011-05-19 12:04:18 UTC) #6
+karlklose

Powered by Google App Engine
This is Rietveld 408576698