Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 6824018: Address symlink attack on dev_debug_vboot. (Closed)

9 years, 8 months ago by Bill Richardson
9 years, 6 months ago


Address symlink attack on dev_debug_vboot. Two things here: Use mktemp to create a unique and new temporary directory to work in, and copy the published log file to a known path in a way that can't be redirected with symlinks. There are also a couple of minor tweaks to cleanup a little bit rot in the information that the script provides. BUG=chromium-os:8947 TEST=manual Boot, wait 60 seconds, look for "/tmp/debug_vboot_noisy.log". It should exist and contain useful and interesting data. Change-Id: Iff9c5c86802ab7fcf3342e82ba128a1795dba16d,, Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=624ee7e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M utility/dev_debug_vboot View 6 chunks +22 lines, -18 lines 2 comments Download


Total messages: 3 (0 generated)
Bill Richardson
9 years, 8 months ago (2011-04-08 21:11:19 UTC) #1
Randall Spangler
LGTM with one suggestion File utility/dev_debug_vboot (right): utility/dev_debug_vboot:21: # TODO(wfrichar): Need to support ...
9 years, 8 months ago (2011-04-08 21:31:13 UTC) #2
9 years, 8 months ago (2011-04-08 21:44:43 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698