history/settings/extensions/help: focus current frame on mousedown if necessary

history/settings/extensions/help: focus current frame on mousedown if necessary

This ensures that key handling works while in a frame.

R=arv@chromium.org
BUG=424135
Committed: https://crrev.com/3c53cfcd3162eecb9544205fcf636adee1f0b4a6
Cr-Commit-Position: refs/heads/master@{#302314}

[Dan Beam, 2014-10-29 02:06:49]

https://codereview.chromium.org/682393002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/menu_button.js (left):

https://codereview.chromium.org/682393002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/menu_button.js:115: e.preventDefault();
this seems like some old windows-ism, maybe?  right clicking outside of a
focused element (and showing a context menu) blurs today (4.75 years later)

[arv (Not doing code reviews), 2014-10-29 08:35:54]

https://codereview.chromium.org/682393002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/menu_button.js (left):

https://codereview.chromium.org/682393002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/menu_button.js:115: e.preventDefault();
On 2014/10/29 02:06:49, Dan Beam wrote:
> this seems like some old windows-ism, maybe?  right clicking outside of a
> focused element (and showing a context menu) blurs today (4.75 years later)

This is intentional. Menu buttons should not be mouse focusable. The focus needs
to stay where it was or the commands do not work, since commands act on the
focused element.

[Dan Beam, 2014-10-30 00:35:50]

https://codereview.chromium.org/682393002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/menu_button.js (left):

https://codereview.chromium.org/682393002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/menu_button.js:115: e.preventDefault();
On 2014/10/29 08:35:54, arv wrote:
> On 2014/10/29 02:06:49, Dan Beam wrote:
> > this seems like some old windows-ism, maybe?  right clicking outside of a
> > focused element (and showing a context menu) blurs today (4.75 years later)
> 
> This is intentional. Menu buttons should not be mouse focusable. The focus
needs
> to stay where it was or the commands do not work, since commands act on the
> focused element.

updated to alternative method. ptal.

[arv (Not doing code reviews), 2014-10-30 08:48:31]

LGTM

Much better.

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/uber/uber_utils.js (right):

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/uber/uber_utils.js:114:
document.body.dispatchEvent(mouseEvent);
Dispatch in document directly?

[Dan Beam, 2014-10-30 17:37:16]

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/uber/uber_utils.js (right):

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/uber/uber_utils.js:114:
document.body.dispatchEvent(mouseEvent);
On 2014/10/30 08:48:31, arv wrote:
> Dispatch in document directly?

there are checks in menu.js that only listen for mouse events on Elements.  want
me to change to documentElement?

[Dan Beam, 2014-10-31 07:37:00]

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/uber/uber_utils.js (right):

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/uber/uber_utils.js:114:
document.body.dispatchEvent(mouseEvent);
On 2014/10/30 17:37:16, Dan Beam wrote:
> On 2014/10/30 08:48:31, arv wrote:
> > Dispatch in document directly?
> 
> there are checks in menu.js that only listen for mouse events on Elements. 
want
> me to change to documentElement?

https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

[arv (Not doing code reviews), 2014-10-31 09:19:37]

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/uber/uber_utils.js (right):

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/uber/uber_utils.js:114:
document.body.dispatchEvent(mouseEvent);
On 2014/10/31 07:37:00, Dan Beam wrote:
> On 2014/10/30 17:37:16, Dan Beam wrote:
> > On 2014/10/30 08:48:31, arv wrote:
> > > Dispatch in document directly?
> > 
> > there are checks in menu.js that only listen for mouse events on Elements. 
> want
> > me to change to documentElement?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

That instanceof check is incorrect :'(

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

If we change the instanceof to Node we can dispatch on document which is a lot
cleaner.

[Dan Beam, 2014-10-31 17:53:43]

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/uber/uber_utils.js (right):

https://codereview.chromium.org/682393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/uber/uber_utils.js:114:
document.body.dispatchEvent(mouseEvent);
On 2014/10/31 09:19:37, arv wrote:
> On 2014/10/31 07:37:00, Dan Beam wrote:
> > On 2014/10/30 17:37:16, Dan Beam wrote:
> > > On 2014/10/30 08:48:31, arv wrote:
> > > > Dispatch in document directly?
> > > 
> > > there are checks in menu.js that only listen for mouse events on Elements.

> > want
> > > me to change to documentElement?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...
> 
> That instanceof check is incorrect :'(
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> If we change the instanceof to Node we can dispatch on document which is a lot
> cleaner.
> 

Done.

[Dan Beam, 2014-10-31 19:32:20]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-31 19:33:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682393002/40001

[commit-bot: I haz the power, 2014-10-31 20:17:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-31 20:18:27]

Patchset 3 (id:??) landed as
https://crrev.com/3c53cfcd3162eecb9544205fcf636adee1f0b4a6
Cr-Commit-Position: refs/heads/master@{#302314}