Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 682383005: [ServiceWorkerCache] Keep the ServiceWorkerCache alive when handling cache IPCs (Closed)

Created:
6 years, 1 month ago by jkarlin
Modified:
6 years, 1 month ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorkerCache] Keep the ServiceWorkerCache alive when handling cache IPCs With this CL, the ServiceWorkerCacheListener holds a reference to the caches that it calls async functions on to ensure that the callbacks are called. Note: Keeping the cache alive longer does not alter cache deletion behavior as cache deletion destroys the cache's backend but not the ServiceWorkerCache object itself. BUG=429161 Committed: https://crrev.com/ec8c1abe68ef1d68e559b8b4ce2a3ee0e23c490a Cr-Commit-Position: refs/heads/master@{#302336}

Patch Set 1 #

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M content/browser/service_worker/service_worker_cache_listener.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_listener.cc View 1 8 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jkarlin
michaeln@chromium.org: Please review changes in all horo@chromium.org: Please review changes in all Thanks!
6 years, 1 month ago (2014-10-31 15:12:59 UTC) #2
michaeln
lgtm
6 years, 1 month ago (2014-10-31 21:16:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682383005/20001
6 years, 1 month ago (2014-10-31 21:29:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 22:14:50 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 22:15:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec8c1abe68ef1d68e559b8b4ce2a3ee0e23c490a
Cr-Commit-Position: refs/heads/master@{#302336}

Powered by Google App Engine
This is Rietveld 408576698