Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 682263002: minidump: Add InitializeFromSnapshot() for MinidumpModuleWriter and MinidumpModuleListWriter (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

minidump: Add InitializeFromSnapshot() for MinidumpModuleWriter and MinidumpModuleListWriter. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/84b44610cfd483fed7bfd3a5627461025be3aeb2

Patch Set 1 #

Patch Set 2 : Don’t allow failure #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -1 line) Patch
M minidump/minidump_module_writer.h View 1 4 chunks +32 lines, -0 lines 0 comments Download
M minidump/minidump_module_writer.cc View 1 4 chunks +77 lines, -0 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 1 3 chunks +143 lines, -1 line 2 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-10-28 21:03:48 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/682263002/diff/20001/minidump/minidump_module_writer_test.cc File minidump/minidump_module_writer_test.cc (right): https://codereview.chromium.org/682263002/diff/20001/minidump/minidump_module_writer_test.cc#newcode654 minidump/minidump_module_writer_test.cc:654: UUID uuids[3] = {}; This doesn't need crashpad:: ...
6 years, 1 month ago (2014-10-29 15:25:24 UTC) #3
Mark Mentovai
https://codereview.chromium.org/682263002/diff/20001/minidump/minidump_module_writer_test.cc File minidump/minidump_module_writer_test.cc (right): https://codereview.chromium.org/682263002/diff/20001/minidump/minidump_module_writer_test.cc#newcode654 minidump/minidump_module_writer_test.cc:654: UUID uuids[3] = {}; Robert Sesek wrote: > This ...
6 years, 1 month ago (2014-10-29 15:35:37 UTC) #4
Mark Mentovai
6 years, 1 month ago (2014-10-29 15:38:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84b44610cfd483fed7bfd3a5627461025be3aeb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698