sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart - Issue 682243004: Redo "Constant fold charCodeAt via constant system"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

Issue 682243004: Redo "Constant fold charCodeAt via constant system" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix analysis warning Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/constant_system_dart.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

index 10a279d8a8ebdf0c399adf0e2c657a28d16e2ea3..3d6e72fb1d831c0c9e3c53e97d2884fb7be92fc0 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

@@ -174,6 +174,7 @@ class JavaScriptConstantSystem extends ConstantSystem {

const JavaScriptBinaryArithmeticOperation(const SubtractOperation());

final truncatingDivide = const JavaScriptBinaryArithmeticOperation(

const TruncatingDivideOperation());

+ final codeUnitAt = const CodeUnitAtRuntimeOperation();

const JavaScriptConstantSystem();

@@ -341,4 +342,4 @@ class JavaScriptMapConstant extends MapConstantValue {

result.addAll(values);

return result;

}