Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 682223006: Make ContentVideoView accept application contexts. (Closed)

Created:
6 years, 1 month ago by Ignacio Solla
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, qinmin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ContentVideoView accept application contexts. This is needed for the WebView, as some apps instantiate it with an application context. We also improve the detection of activity contexts. BUG=428952 Committed: https://crrev.com/0e726250f02bd44636a1cc3a4660dd90d30d3a64 Cr-Commit-Position: refs/heads/master@{#302264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ignacio Solla
6 years, 1 month ago (2014-10-30 20:06:47 UTC) #2
michaelbai
I assumed you fully test it in WebView, if so LGTM
6 years, 1 month ago (2014-10-30 20:51:45 UTC) #4
Ignacio Solla
On 2014/10/30 20:51:45, michaelbai wrote: > I assumed you fully test it in WebView, if ...
6 years, 1 month ago (2014-10-31 09:48:05 UTC) #5
benm (inactive)
lgtm
6 years, 1 month ago (2014-10-31 13:42:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682223006/1
6 years, 1 month ago (2014-10-31 13:47:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 14:37:22 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:37:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e726250f02bd44636a1cc3a4660dd90d30d3a64
Cr-Commit-Position: refs/heads/master@{#302264}

Powered by Google App Engine
This is Rietveld 408576698