Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 682193002: Deterministic recipe: Print the number of files equals or differents (Closed)

Created:
6 years, 1 month ago by Sébastien Marchand
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Deterministic recipe: Print the number of files equals or differents BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292705

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix calculation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sébastien Marchand
PTAL.
6 years, 1 month ago (2014-10-28 20:27:37 UTC) #3
M-A Ruel
lgtm with right values https://codereview.chromium.org/682193002/diff/20001/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py (right): https://codereview.chromium.org/682193002/diff/20001/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py#newcode68 scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:68: len(first_list & second_list), res) calculation ...
6 years, 1 month ago (2014-10-28 20:31:56 UTC) #4
Sébastien Marchand
Thanks, commmitting. https://codereview.chromium.org/682193002/diff/20001/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py (right): https://codereview.chromium.org/682193002/diff/20001/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py#newcode68 scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:68: len(first_list & second_list), res) On 2014/10/28 20:31:56, ...
6 years, 1 month ago (2014-10-28 20:36:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682193002/40001
6 years, 1 month ago (2014-10-28 20:38:02 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 20:38:41 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as 292705

Powered by Google App Engine
This is Rietveld 408576698