Make the kiosk code not depend on Ash in Athena

Make the kiosk code not depend on Ash in Athena

BUG=426561
TEST=None

Committed: https://crrev.com/a7b4216aa50f7b0e55dae32a612d3641a72c25ec
Cr-Commit-Position: refs/heads/master@{#301978}

[pkotwicz, 2014-10-29 00:56:52]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-10-29 00:59:50]

pkotwicz@chromium.org changed reviewers:
+ mukai@chromium.org

[pkotwicz, 2014-10-29 00:59:51]

mukai@ PTAL

[Jun Mukai, 2014-10-29 01:03:27]

https://codereview.chromium.org/682183003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc (right):

https://codereview.chromium.org/682183003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc:20: #if
defined(USE_ASH)
IIRC Athena still links to ash right now, so this ifdefs are not necessary right
now.

https://codereview.chromium.org/682183003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/kiosk_external_update_notification.cc (right):

https://codereview.chromium.org/682183003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/kiosk_external_update_notification.cc:126: gfx::Size
rs;
how about CHECK(ash::Shell::HasInstance()) ?

[pkotwicz, 2014-10-29 01:49:05]

I am in the process of making Athena not link against Ash anymore. I have an 80
file long change locally which accomplishes the task

[Jun Mukai, 2014-10-29 02:07:27]

On 2014/10/29 01:49:05, pkotwicz wrote:
> I am in the process of making Athena not link against Ash anymore. I have an
80
> file long change locally which accomplishes the task

This CL itself LGTM under that context.

I'm a bit wondering if we could exclude kiosk_mode_idle_logout.cc and
kiosk_external_update_notification.cc themselves from athena build, rather than
adding ifdef(USE_ASH).

[pkotwicz, 2014-10-29 19:22:10]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-10-29 19:22:10]

Oshima for OWNERS. I have excluded kiosk_mode_idle_logout.cc and
kiosk_external_update_notification.cc from the Athena build as requested

[oshima, 2014-10-29 19:33:45]

On 2014/10/29 19:22:10, pkotwicz wrote:
> Oshima for OWNERS. I have excluded kiosk_mode_idle_logout.cc and
> kiosk_external_update_notification.cc from the Athena build as requested

kiosk mode won't make sense at all in athena (and long term plan is to switch to
app_shell).
Can we simply exclude app_mode stuff instead of adding ifdef?

[oshima, 2014-10-29 20:59:11]

lgtm

[pkotwicz, 2014-10-29 21:00:41]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-29 21:01:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682183003/40001

[commit-bot: I haz the power, 2014-10-29 21:06:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 21:06:29]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/75410)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkotwicz, 2014-10-29 22:02:18]

Patchset #3 (id:60001) has been deleted

[pkotwicz, 2014-10-29 22:02:35]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-29 22:03:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/682183003/80001

[commit-bot: I haz the power, 2014-10-29 23:38:10]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2014-10-29 23:38:53]

Patchset 3 (id:??) landed as
https://crrev.com/a7b4216aa50f7b0e55dae32a612d3641a72c25ec
Cr-Commit-Position: refs/heads/master@{#301978}