Issue 682153003: Add a sky_server for running sky apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682153003: Add a sky_server for running sky apps (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
esprehn, abarth-chromium

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a sky_server for running sky apps This automatically adds /sky and /mojo mappings to the generated files for each. Also taught skydb to use this new server. R=esprehn@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/62431b74e967123b9eb76211320e8ddd45965f77

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -8 lines)			Patch
	A	sky/tools/sky_server	View		1 chunk	+46 lines, -0 lines	1 comment	Download
	M	sky/tools/skydb	View		3 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

esprehn

lgtm https://codereview.chromium.org/682153003/diff/1/sky/tools/sky_server File sky/tools/sky_server (right): https://codereview.chromium.org/682153003/diff/1/sky/tools/sky_server#newcode11 sky/tools/sky_server:11: CONFIG_DIRECTORY = 'Debug' This means this can't work ...

6 years, 1 month ago (2014-10-28 19:38:07 UTC) #3

eseidel

6 years, 1 month ago (2014-10-28 19:42:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62431b74e967123b9eb76211320e8ddd45965f77 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages