Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 682133003: [Password Manager] Add link to remotely manage passowrds on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/password_manager_handler.h ('k') | components/password_manager.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/password_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc
index 7aa8bea4ff3d26aa8ad4a7483128eb53d031e0ce..c75c048ed01ea0eb41bb3c1696988cb2ba040161 100644
--- a/chrome/browser/ui/webui/options/password_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/prefs/pref_service.h"
#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_split.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/chrome_notification_types.h"
@@ -18,12 +19,14 @@
#include "chrome/common/url_constants.h"
#include "chrome/grit/generated_resources.h"
#include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/core/common/experiments.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_source.h"
#include "content/public/browser/user_metrics.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "net/base/net_util.h"
+#include "ui/base/l10n/l10n_util.h"
namespace options {
@@ -69,6 +72,21 @@ void PasswordManagerHandler::GetLocalizedValues(
localized_strings->SetString("passwordManagerLearnMoreURL",
chrome::kPasswordManagerLearnMoreURL);
+ localized_strings->SetString("passwordsManagePasswordsLink",
+ chrome::kPasswordManagerAccountDashboardURL);
+
+ std::vector<base::string16> pieces;
+ base::SplitStringDontTrim(
+ l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_REMOTE_TEXT),
+ '|', // separator
+ &pieces);
+ DCHECK_EQ(3U, pieces.size());
+ localized_strings->SetString("passwordsManagePasswordsBeforeLinkText",
+ pieces[0]);
+ localized_strings->SetString("passwordsManagePasswordsLinkText", pieces[1]);
+ localized_strings->SetString("passwordsManagePasswordsAfterLinkText",
+ pieces[2]);
+
bool disable_show_passwords = false;
#if defined(OS_WIN) && defined(USE_ASH)
@@ -106,6 +124,13 @@ void PasswordManagerHandler::InitializeHandler() {
password_manager_presenter_.Initialize();
}
+void PasswordManagerHandler::InitializePage() {
+ base::FundamentalValue visible(
+ password_manager::ManageAccountLinkExperimentEnabled());
+ web_ui()->CallJavascriptFunction(
+ "PasswordManager.setManageAccountLinkVisibility", visible);
+}
+
void PasswordManagerHandler::HandleRemoveSavedPassword(
const base::ListValue* args) {
std::string string_value = base::UTF16ToUTF8(ExtractStringValue(args));
« no previous file with comments | « chrome/browser/ui/webui/options/password_manager_handler.h ('k') | components/password_manager.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698