Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: commit-queue/pending_manager.py

Issue 68213029: CQ: catch more exceptions when applying a patch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit-queue/pending_manager.py
===================================================================
--- commit-queue/pending_manager.py (revision 235478)
+++ commit-queue/pending_manager.py (working copy)
@@ -23,6 +23,7 @@
import checkout
import git_cl
import patch
+import ssl
import subprocess2
import errors
@@ -90,7 +91,7 @@
if e.stdout:
out += '\n%s' % e.stdout
raise base.DiscardPending(self, out)
- except urllib2.HTTPError as e:
+ except (ssl.SSLError, urllib2.HTTPError, urllib2.URLError) as e:
raise base.DiscardPending(
self,
('Failed to request the patch to try. Please note that binary files '
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698