ONC policy: Support SSID and Security change.

ONC policy: Support SSID and Security change.

If the SSID of a ONC policy is changed without changing the GUID, this lead to a partial policy application where everything except the SSID is changed.
This happened because Shill doesn't allow changes of the SSID property after the network creation but the policy application code didn't respect that.

With this change, it's ensured that the respective network configuration (profile entry), is deleted and rewritten on each SSID change.

The same applies to the Security type of the network.

BUG=319362
R=bartfab@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235410

[pneubeck (no reviews), 2013-11-15 10:46:25]

PTAL. Please ask me if any questions arise.

[bartfab (slow), 2013-11-15 15:37:50]

lgtm

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/policy_a...
File chromeos/network/policy_applicator.cc (right):

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/policy_a...
chromeos/network/policy_applicator.cc:172: scoped_ptr<base::DictionaryValue>
new_shill_properties =
Nit: #include "base/memory/scoped_ptr.h"

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/policy_a...
chromeos/network/policy_applicator.cc:191: << new_guid << " because of
significant policy changes.";
Nit: "Significant" has a very fuzzy meaning in colloquial speech. How about
"because identifying properties changed"?

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/shill_pr...
File chromeos/network/shill_property_util.h (right):

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/shill_pr...
chromeos/network/shill_property_util.h:65: // are not supported. Returns true
only if all required properties could be
Nit: "Returns true only if all required properties could be copied" does not
really make sense in the description of this method because it is not meant for
copying (the copying is an implementation detail). Could you rephrase this?

[pneubeck (no reviews), 2013-11-15 15:44:54]

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/policy_a...
File chromeos/network/policy_applicator.cc (right):

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/policy_a...
chromeos/network/policy_applicator.cc:172: scoped_ptr<base::DictionaryValue>
new_shill_properties =
On 2013/11/15 15:37:50, bartfab wrote:
> Nit: #include "base/memory/scoped_ptr.h"

Done.

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/policy_a...
chromeos/network/policy_applicator.cc:191: << new_guid << " because of
significant policy changes.";
On 2013/11/15 15:37:50, bartfab wrote:
> Nit: "Significant" has a very fuzzy meaning in colloquial speech. How about
> "because identifying properties changed"?

Done.

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/shill_pr...
File chromeos/network/shill_property_util.h (right):

https://codereview.chromium.org/68213018/diff/30001/chromeos/network/shill_pr...
chromeos/network/shill_property_util.h:65: // are not supported. Returns true
only if all required properties could be
On 2013/11/15 15:37:50, bartfab wrote:
> Nit: "Returns true only if all required properties could be copied" does not
> really make sense in the description of this method because it is not meant
for
> copying (the copying is an implementation detail). Could you rephrase this?
whoops. copied too much.
Done.

[commit-bot: I haz the power, 2013-11-15 15:46:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/68213018/110001

[commit-bot: I haz the power, 2013-11-15 16:34:56]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[pneubeck (no reviews), 2013-11-15 20:20:29]

Committed patchset #2 manually as r235410 (presubmit successful).