Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: net/http/http_auth_handler_digest.cc

Issue 68213017: Fix HTTP protocol scheme debugging checks for WebSockets (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Additional minor #include tweak. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_cache.cc ('k') | net/http/http_util_icu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_digest.cc
diff --git a/net/http/http_auth_handler_digest.cc b/net/http/http_auth_handler_digest.cc
index 904430ecb409b22136d8f11fcf5645aca7fc6da6..a8e301a02e89828d848eccbfd2b4491402ef419c 100644
--- a/net/http/http_auth_handler_digest.cc
+++ b/net/http/http_auth_handler_digest.cc
@@ -18,6 +18,7 @@
#include "net/http/http_auth.h"
#include "net/http/http_request_info.h"
#include "net/http/http_util.h"
+#include "url/gurl.h"
namespace net {
@@ -304,7 +305,7 @@ void HttpAuthHandlerDigest::GetRequestMethodAndPath(
const GURL& url = request->url;
if (target_ == HttpAuth::AUTH_PROXY &&
- (url.SchemeIs("https") || url.SchemeIs("ws") || url.SchemeIs("wss"))) {
+ (url.SchemeIs("https") || url.SchemeIsWSOrWSS())) {
szym 2013/11/19 04:39:12 Double checking: is "ws" okay here? ("http" is not
tyoshino (SeeGerritForStatus) 2013/11/19 04:53:47 WebSockets use CONNECT method for both non-secure
*method = "CONNECT";
*path = GetHostAndPort(url);
} else {
« no previous file with comments | « net/http/http_auth_cache.cc ('k') | net/http/http_util_icu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698