Clearer help in gclient-new-workdir.py

gclient-new-workdir.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Usage:
 #    gclient-new-workdir.py <repository> <new_workdir> [<branch>]
 #
 
 import os
 import shutil
 import subprocess
 import sys
 
 
 def parse_options(argv):
-  assert not sys.platform.startswith("win")
+  if sys.platform == "win32":
+    print >> sys.stderr, ("This script cannot run on Windows because it uses"
+                          "symlinks.")

[iannucci, 2013/11/13 17:57:30]

As M-A pointed out, could convert all "" quoted strings to '' quoted strings?
(at least the ones you touched, if you don't want to change the whole file.

Also, I prefer

print >> ..., (
    "This .... symlinks.")

especially since the string could all fit on a line.

+    sys.exit(1)
 
   if len(argv) != 3:
-    print("usage: gclient-new-workdir.py <repository> <new_workdir>")
+    print("""usage: gclient-new-workdir.py <repository> <new_workdir>
+
+    Clone an existing gclient directory, taking care of all sub-repositories

[M-A Ruel, 2013/11/13 17:17:33]

You want the text to be +4 at output?

[iannucci, 2013/11/13 17:57:30]

I think you want to pass this string through
http://docs.python.org/2/library/textwrap.html#textwrap.dedent so that you don't
get awkward indentation.

+    Works similarly to 'git new-workdir'.
+
+    <repository> must be a absolute path
+    <new_workdir> must not exist
+    """)
     sys.exit(1)
 
-  repository = argv[1]
+  repository = os.path.abspath(argv[1])
   new_workdir = argv[2]
 
   if not os.path.exists(repository):
-    print("Repository does not exist: " + repository)
+    print >> sys.stderr, ("Repository does not exist: " + repository)
     sys.exit(1)
 
   if os.path.exists(new_workdir):
-    print("New workdir already exists: " + new_workdir)
+    print >> sys.stderr, ("New workdir already exists: " + new_workdir)

[iannucci, 2013/11/13 17:57:30]

What do you think about a print_err function do this?

     sys.exit(1)
 
   return repository, new_workdir
 
 
 def main(argv):
   repository, new_workdir = parse_options(argv)
 
   gclient = os.path.join(repository, ".gclient")
   if not os.path.exists(gclient):
-    print("No .gclient file: " + gclient)
+    print >> sys.stderr, ("No .gclient file: " + gclient)
 
   gclient_entries = os.path.join(repository, ".gclient_entries")
   if not os.path.exists(gclient_entries):
-    print("No .gclient_entries file: " + gclient_entries)
+    print >> sys.stderr, ("No .gclient_entries file: " + gclient_entries)
 
   os.mkdir(new_workdir)
   os.symlink(gclient, os.path.join(new_workdir, ".gclient"))
   os.symlink(gclient_entries, os.path.join(new_workdir, ".gclient_entries"))
 
   for root, dirs, _ in os.walk(repository):
     if ".git" in dirs:
       workdir = root.replace(repository, new_workdir, 1)
       make_workdir(os.path.join(root, ".git"),
                    os.path.join(workdir, ".git"))
@@ skipping 29 matching lines @@
   if not os.path.exists(os.path.join(repository, link)):
     return
   link_dir = os.path.dirname(os.path.join(new_workdir, link))
   if not os.path.exists(link_dir):
     os.makedirs(link_dir)
   os.symlink(os.path.join(repository, link), os.path.join(new_workdir, link))
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))