Clearer help in gclient-new-workdir.py

gclient-new-workdir.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Usage:
 #    gclient-new-workdir.py <repository> <new_workdir> [<branch>]
 #
 
 import os
+import os.path

[M-A Ruel, 2013/11/12 17:40:07]

Not needed.

 import shutil
 import subprocess
 import sys
 
 
 def parse_options(argv):
-  assert not sys.platform.startswith("win")
+  if sys.platform.startswith("win"):

[M-A Ruel, 2013/11/12 17:40:07]

On windows, it'll always be 'win32', so use:
if sys.platform == 'win32':

+    print("This script cannot run on Windows because it uses symlinks.")

[M-A Ruel, 2013/11/12 17:40:07]

you should print to sys.stderr. I see the rest of the code didn't do that
properly.

+    sys.exit(1)
 
   if len(argv) != 3:
-    print("usage: gclient-new-workdir.py <repository> <new_workdir>")
+    print("""usage: gclient-new-workdir.py <repository> <new_workdir>
+
+    <repository> must be a absolute path
+    <new_workdir> must not exist
+    """)
     sys.exit(1)
 
   repository = argv[1]
   new_workdir = argv[2]
 
+  if not os.path.isabs(argv[1]):
+    print("First argument (repository) must be an absolute path.")

[M-A Ruel, 2013/11/12 17:40:07]

Why not
argv[1] = os.path.abspath(argv[1])
?

+    sys.exit(1)
+
   if not os.path.exists(repository):
     print("Repository does not exist: " + repository)
     sys.exit(1)
 
   if os.path.exists(new_workdir):
     print("New workdir already exists: " + new_workdir)
     sys.exit(1)
 
   return repository, new_workdir
 
@@ skipping 50 matching lines @@
   if not os.path.exists(os.path.join(repository, link)):
     return
   link_dir = os.path.dirname(os.path.join(new_workdir, link))
   if not os.path.exists(link_dir):
     os.makedirs(link_dir)
   os.symlink(os.path.join(repository, link), os.path.join(new_workdir, link))
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))