Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 682123004: X87: Classes: Add basic support for properties. (Closed)

Created:
6 years, 1 month ago by chunyang.dai
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Classes: Add basic support for properties. commit r24934. original commit message: This adds the properties to the prototype and the constructor. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
WL. PTAL.
6 years, 1 month ago (2014-10-29 07:46:01 UTC) #2
Weiliang
lgtm
6 years, 1 month ago (2014-10-29 07:47:20 UTC) #3
Weiliang
Committed as r24963
6 years, 1 month ago (2014-10-29 08:29:08 UTC) #4
arv (Not doing code reviews)
6 years, 1 month ago (2014-10-29 08:36:53 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698