Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 6821025: entd: move opencryptoki initialization out of entd (Closed)

Created:
8 years, 4 months ago by kmixter1
Modified:
8 years, 3 months ago
Reviewers:
rginda
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

entd: move opencryptoki initialization out of entd Look for a file /home/chronos/.cryptohome-init-pkcs11 and expect cryptohome to initialize the PKCS#11 token, disabling that interface in newer extensions. Change-Id: I363ec0ef093d58d793a3d75e22dee96b58bdacd3 R=rginda@chromium.org BUG=chromium-os:12304 TEST= old extension / new entd (w/ and w/o flag) new extension / old entd: new extension / new entd (w/ and w/o flag): When flag is set with new entd, Initialize button disappears and we wait for cryptohomed to signal the TPM token is ready. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3cb4347

Patch Set 1 #

Patch Set 2 : Remove PKCS#11 (re-)initialization UI #

Patch Set 3 : Remove more unnecessary UI #

Patch Set 4 : switch to using a flag to expect cryptohome to init pkcs11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -7 lines) Patch
M base_policy/policy-utils.js View 1 2 3 5 chunks +13 lines, -3 lines 0 comments Download
M bin/entdwife.sh View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M main.cc View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download
M reference_extension/client.js View 1 2 3 6 chunks +31 lines, -3 lines 0 comments Download
M reference_extension/options.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tpm.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M tpm.cc View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kmixter1
8 years, 4 months ago (2011-04-09 01:32:22 UTC) #1
rginda
On 2011/04/09 01:32:22, kmixter1 wrote: LGTM as long as you wait until cryptohomed actually takes ...
8 years, 4 months ago (2011-04-11 21:29:07 UTC) #2
kmixter1
PTAL - I updated this to include the corresponding base extension changes to remove the ...
8 years, 4 months ago (2011-04-15 00:38:30 UTC) #3
rginda
On 2011/04/15 00:38:30, kmixter1 wrote: > PTAL - I updated this to include the corresponding ...
8 years, 4 months ago (2011-04-15 16:14:17 UTC) #4
kmixter1
PTAL - pretty big direction shift - now change behavior based on a flag.
8 years, 4 months ago (2011-04-19 02:23:08 UTC) #5
rginda
8 years, 4 months ago (2011-04-19 16:39:30 UTC) #6
On 2011/04/19 02:23:08, kmixter1 wrote:
> PTAL - pretty big direction shift - now change behavior based on a flag.

LGTM

Powered by Google App Engine
This is Rietveld 408576698