Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 68203031: telemetry: Add tough scheduling cases (Closed)

Created:
7 years, 1 month ago by Sami
Modified:
7 years ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

telemetry: Add tough scheduling cases This patch introduces a tough scheduling page set with pages designed to exercise various paths in the compositor scheduler. There are four main test cases: 1. Simple text page 2. Page with touch-handler driven scrolling 3. Page with requestAnimationFrame animation 4. Page with CSS animation, rAF and a touch handler Each test case has a number of subvariants that introduce synthetic delays to different parts of the pipeline. We measure the resulting frame rate, smoothness (and soon latency). BUG=307841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238793

Patch Set 1 #

Patch Set 2 : Configure synthetic delays. #

Patch Set 3 : Full test set. #

Total comments: 10

Patch Set 4 : Address review comments, set all delays atomically, no need to restart browser. #

Patch Set 5 : Update page action. #

Patch Set 6 : Use '?' instead of '#' to unbreak navigation. Reset delays in all tests. #

Patch Set 7 : Exclude set_synthetic_delays action for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2007 lines, -0 lines) Patch
M tools/perf/benchmarks/smoothness.py View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_scheduling_cases.json View 1 2 3 4 5 1 chunk +266 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_scheduling_cases/div_touch_handler.html View 1 2 3 1 chunk +282 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_scheduling_cases/raf.html View 1 2 3 1 chunk +283 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_scheduling_cases/raf_canvas.html View 1 2 3 1 chunk +289 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_scheduling_cases/raf_touch_animation.html View 1 2 3 1 chunk +320 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_scheduling_cases/simple_text_page.html View 1 2 3 1 chunk +260 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_scheduling_cases/touch_handler_scrolling.html View 1 2 3 1 chunk +297 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Sami
Here are the scheduler test cases. How do you like this way of hooking up ...
7 years, 1 month ago (2013-11-22 18:30:54 UTC) #1
nduca
+ernstm
7 years ago (2013-11-24 19:14:27 UTC) #2
nduca
this lgtm, pending manfred liking it. Content wise, should we also have stuff for heavy ...
7 years ago (2013-11-24 19:22:38 UTC) #3
nduca
https://codereview.chromium.org/68203031/diff/60001/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/68203031/diff/60001/tools/perf/benchmarks/smoothness.py#newcode34 tools/perf/benchmarks/smoothness.py:34: """Measures rendering statistics while interacting with pages that have ...
7 years ago (2013-11-24 19:22:46 UTC) #4
ernstm
Variance decreases with browser restart for rasterize_and_record measurement. That's why this measurement always uses it. ...
7 years ago (2013-11-26 01:06:38 UTC) #5
Sami
On 2013/11/26 01:06:38, Manfred Ernst wrote: > Variance decreases with browser restart for rasterize_and_record measurement. ...
7 years ago (2013-11-26 20:06:33 UTC) #6
ernstm
On 2013/11/26 20:06:33, Sami wrote: > On 2013/11/26 01:06:38, Manfred Ernst wrote: > > Variance ...
7 years ago (2013-11-27 05:49:42 UTC) #7
Sami
https://codereview.chromium.org/68203031/diff/60001/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/68203031/diff/60001/tools/perf/benchmarks/smoothness.py#newcode34 tools/perf/benchmarks/smoothness.py:34: """Measures rendering statistics while interacting with pages that have ...
7 years ago (2013-11-29 19:29:17 UTC) #8
ernstm
LGTM
7 years ago (2013-12-03 21:54:51 UTC) #9
Sami
Thanks. I'll land this without the set_synthetic_delays action since that part is still in flux.
7 years ago (2013-12-04 16:22:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/68203031/220001
7 years ago (2013-12-04 16:22:33 UTC) #11
commit-bot: I haz the power
7 years ago (2013-12-04 22:13:47 UTC) #12
Message was sent while issue was closed.
Change committed as 238793

Powered by Google App Engine
This is Rietveld 408576698